Skip to content

move static methods from scan_image to computations.#211

Merged
SimoneAriens merged 4 commits intomainfrom
cleanup-scan_image
Apr 1, 2026
Merged

move static methods from scan_image to computations.#211
SimoneAriens merged 4 commits intomainfrom
cleanup-scan_image

Conversation

@Raytesnel
Copy link
Copy Markdown
Collaborator

move some last leftovers from scan-image to different files.

@Raytesnel Raytesnel self-assigned this Mar 26, 2026
@Raytesnel Raytesnel force-pushed the cleanup-scan_image branch from f16d740 to a9133e0 Compare March 26, 2026 13:44
@Raytesnel Raytesnel force-pushed the cleanup-scan_image branch from a9133e0 to 94c3e4d Compare March 26, 2026 13:44
Comment thread packages/scratch-core/tests/computations/test_normalize.py
Comment thread packages/scratch-core/src/computations/normalization.py
Copy link
Copy Markdown
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the function name, for the rest looks good to me :)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Diff Coverage

Diff: origin/main..HEAD, staged and unstaged changes

  • packages/scratch-core/src/computations/normalization.py (100%)
  • packages/scratch-core/src/container_models/scan_image.py (100%)

Summary

  • Total: 19 lines
  • Missing: 0 lines
  • Coverage: 100%

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 96% 92%
computations 94% 67%
container_models 99% 100%
conversion 96% 89%
conversion.export 99% 93%
conversion.filter 97% 89%
conversion.leveling 100% 100%
conversion.leveling.solver 100% 75%
conversion.plots 99% 88%
conversion.preprocess_impression 99% 91%
conversion.preprocess_striation 90% 62%
conversion.profile_correlator 96% 82%
conversion.surface_comparison 99% 89%
conversion.surface_comparison.cell_registration 100% 90%
extractors 97% 75%
mutations 100% 100%
parsers 97% 50%
parsers.patches 89% 60%
preprocessors 99% 100%
processors 100% 83%
renders 99% 50%
utils 71% 100%
Summary 98% (3264 / 3336) 87% (340 / 392)

Minimum allowed line rate is 50%

@SimoneAriens SimoneAriens merged commit 25182f6 into main Apr 1, 2026
4 checks passed
@SimoneAriens SimoneAriens deleted the cleanup-scan_image branch April 1, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants