Skip to content

feat(rpcv10): add support for proof_facts in subscription tags for starknet_subscribeNewTransactions#3390

Merged
rodrodros merged 21 commits intomainfrom
maksym/rpcv10-subscription-tags
Feb 18, 2026
Merged

feat(rpcv10): add support for proof_facts in subscription tags for starknet_subscribeNewTransactions#3390
rodrodros merged 21 commits intomainfrom
maksym/rpcv10-subscription-tags

Conversation

@MaksymMalicki
Copy link
Copy Markdown
Contributor

@MaksymMalicki MaksymMalicki commented Jan 26, 2026

No description provided.

EgeCaner
EgeCaner requested changes Jan 27, 2026
View reviewed changes
Comment thread rpc/v10/subscriptions_test.go Outdated
Comment thread rpc/v10/subscriptions_test.go Outdated
Comment thread rpc/v10/subscriptions_test.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.27%. Comparing base (5d74f82) to head (9e095f9).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v10/subscriptions.go 64.70% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
- Coverage   74.46%   74.27%   -0.19%     
==========================================
  Files         379      379              
  Lines       35637    35688      +51     
==========================================
- Hits        26537    26508      -29     
- Misses       6938     6999      +61     
- Partials     2162     2181      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

infrmtcs
infrmtcs reviewed Feb 5, 2026
View reviewed changes
Comment thread rpc/v10/response_flags.go Outdated
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch 2 times, most recently from c0b55b8 to 9b8cc56 Compare February 6, 2026 10:38
@EgeCaner EgeCaner mentioned this pull request Feb 6, 2026
Merged
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch 2 times, most recently from 80afe41 to 8c1afb1 Compare February 13, 2026 13:59
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-subscription-tags branch from f90a7c1 to 0246be7 Compare February 13, 2026 16:13
@thiagodeev thiagodeev self-requested a review February 17, 2026 12:32
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch 2 times, most recently from 58bad55 to 66575f7 Compare February 17, 2026 15:00
Base automatically changed from maksym/rpcv10-response-flags to main February 17, 2026 15:45
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-subscription-tags branch from ce39ca6 to 15ce5a5 Compare February 17, 2026 16:13
@rodrodros rodrodros merged commit 221bc34 into main Feb 18, 2026
21 of 23 checks passed
@rodrodros rodrodros deleted the maksym/rpcv10-subscription-tags branch February 18, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infrmtcs infrmtcs infrmtcs approved these changes

@rodrodros rodrodros rodrodros approved these changes

@thiagodeev thiagodeev thiagodeev approved these changes

@EgeCaner EgeCaner EgeCaner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaksymMalicki @infrmtcs @rodrodros @thiagodeev @EgeCaner