BlackrockRawIO: Add _get_blackrock_timestamps for per-sample timestamp retrieval#1816
Merged
alejoe91 merged 1 commit intoNeuralEnsemble:masterfrom Feb 13, 2026
Conversation
alejoe91
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a private method
_get_blackrock_timestampstoBlackrockRawIOthat returns per-sample timestamps in seconds as a float64 array, implementing pillar 3 ("expose original acquisition timestamps") of the gap-handling API proposal in #1773. For PTP formats, actual per-sample hardware timestamps are extracted; for all other formats, timestamps within each data block are interpolated from the first sample using the sampling rate. The method is private for now to allow discussion of a public API onBaseRawIOlater, but downstream users can already use it in the meantime.Another reason to add this logic first is that it paves the way for generalizing
gap_tolerance_msto standard format variants (v2.2/v2.3/v3.0). Currently gap handling only works for PTP; by establishing a uniform per-sample timestamp representation across all formats, the segmentation pipeline can be rewritten as a single code path that appliesnp.diffbased gap detection to any variant, eliminating the format-specific branching in_segment_nsx_dataand making the code simpler.