Merged
Conversation
- bids_interface: crop signal to exact data records for BDF/EDF export (handles both integer and non-integer sampling rates), add standard montage fiducials when missing from head coordinate frame - bnci_2016_002: fix KeyError in event_mapping for marker_labels - bnci_2022_001: handle lowercase 'trigger' attribute in .mat files - kaneshiro2015: detect truncated downloads via HTTP range request and re-download automatically (Stanford server uses chunked transfer) - lee2024: add annotations from stim channel events for BIDS compat, fallback to dummy annotation when stim channel is empty - martinezcagigal2023_checker/pary: convert data from uV to V before creating RawArray (fixes BDF physical_range overflow) - triana_guzman2024: gracefully skip subjects with corrupt .set files - zuo2025: handle 'data' key in addition to 'EEG' in .mat files
- chang2025: gracefully skip subjects with missing directories or .set files instead of crashing (subject S211 has no data upstream) - guttmann_flury2025: fix channel types (Trig->stim, HEO/VEO->eog, M1/M2->misc) to prevent BDF export OSError from trigger channel values exceeding EEG physical range limits
Force datasets to include all runs/conditions that are excluded by default for benchmarking convenience: Lee2019 test runs, Speier2017 online runs, RomaniBF2025ERP inference/failed sessions, Sosulski2019 SOA 60ms. Also add BDF to _FORMAT_EXTENSION_MAP.
- Expose motor_imagery and mental_arithmetic as keyword-only parameters on Shin2017A (default: MI=True, MA=False) and Shin2017B (default: MI=False, MA=True), preserving backward compatibility - Update conversion script to re-instantiate Shin2017A/B with both conditions enabled for complete NEMAR deposits
- Lee2019: add 'rest' annotation to resting state runs so BIDS export doesn't fail with missing annotations error - bids_interface: add BDF to _FORMAT_EXTENSION_MAP (was only local edit) - bbci_eeg_fnirs: Shin2017A/B motor_imagery/mental_arithmetic params (already in previous commit, ensuring consistency)
- Add 'rest' annotation for BIDS export compatibility - Include EMG channels in resting state runs when available, matching the main run data structure
…oads, not upstream
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28f4292248
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Bru <b.aristimunha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.