Support NeuroConv 0.9.0#1053
Closed
bendichter wants to merge 18 commits intomainfrom
Closed
Conversation
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
36f982e to
80bdd45
Compare
bendichter
changed the base branch from
support-neuroconv-0.8.3
to
support-neuroconv-0.8.0
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
80bdd45 to
d4461ba
Compare
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
19a1098 to
9d91c0a
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
d4461ba to
4a7962a
Compare
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
7a176aa to
7ced663
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
0576c15 to
e5f47f2
Compare
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
7ced663 to
22eda17
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
ce3a3de to
387166d
Compare
added 7 commits
February 12, 2026 19:54
Changes from 0.6.1: - Bump neuroconv to 0.7.0 - Fix Table.js: value == '' incorrectly treated 0 as empty (strict equality) - Remove UnitColumn required constraint - Sync UnitColumns with Unit schema properties (frontend linked-table validation) - Pin dandi < 0.74.0 (0.74.0 renamed dandi-staging to dandi-sandbox) - Set DANDI_STAGING_API_KEY for dandi < 0.74 compatibility
- Add ElectrodeColumns sync: ensure ElectrodeColumns includes entries for all Electrode schema properties (mirrors UnitColumns sync fix) - Remove ElectrodeColumn required fields (mirrors UnitColumn fix) - Update temporally_align_data_interfaces to accept metadata and conversion_options kwargs (neuroconv 0.7.0 API change)
Instead of pinning dandi < 0.74.0, register 'dandi-staging' as an alias for 'dandi-sandbox' in dandi's known_instances dict. This allows neuroconv 0.6.1 (which uses 'dandi-staging' internally) to work with both old and new dandi versions.
The update_recording_properties_from_table_as_json function requires data_type on each column entry. Infer it from the schema property type.
h5py 3.13+ requires HDF5 1.14.4 features (_H5T_IEEE_F16BE_g) that are not available in pytables 3.10.2's bundled HDF5 1.14.2. This causes a dlopen failure in PyInstaller builds where both libraries' HDF5 dylibs are co-bundled.
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
b2594f4 to
6e3440f
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
387166d to
360ffbd
Compare
neuroconv 0.7.0+ populates Device metadata with 'manufacturer' field. pynwb's Device schema includes it but sets additionalProperties: false. The frontend resolution may not properly resolve the Device definition, causing validation to reject 'manufacturer' as an additional property. Set additionalProperties: true to allow it.
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
6e3440f to
5d73094
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
4a22e4a to
ded4f72
Compare
added 2 commits
February 12, 2026 21:33
…ndbox dandi >= 0.74.0 has an explicit ValueError check rejecting 'dandi-staging' after the known_instances lookup. Patching known_instances alone isn't enough. Now also patch dandi.utils.get_instance to remap 'dandi-staging' to 'dandi-sandbox' before the check runs.
- Bump neuroconv to 0.8.0 - Remove neo == 0.14.1 pin (neuroconv >= 0.7.5 compatible) - Remove pandas < 3.0 pin (neuroconv 0.8.0 compatible) - Loosen ndx-pose and nwbinspector pins for pynwb 3 compat
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
5d73094 to
ad29175
Compare
- Bump neuroconv to 0.9.0 - Change staging=sandbox to sandbox=sandbox (neuroconv 0.9.0 API) - Remove DANDI_STAGING_API_KEY from CI (neuroconv 0.9.0 uses dandi-sandbox natively)
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
e64d15e to
d281888
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
ea2d705 to
3a06546
Compare
bendichter
force-pushed
the
support-neuroconv-0.8.0
branch
from
8b729d8 to
17f51d7
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
6ce9e93 to
391aa0e
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
f899229 to
c6df28e
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
9fbfd8a to
2a89109
Compare
bendichter
force-pushed
the
support-neuroconv-0.9.0
branch
from
b469b2c to
e99f675
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
|
closing in favor of #1056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
dandi < 0.74.0pin — neuroconv 0.9.0 usesdandi-sandboxinstead ofdandi-staging(PR #1588)DANDI_STAGING_API_KEYenv var setting (no longer needed, keepDANDI_SANDBOX_API_KEY)Notable neuroconv 0.9.0 changes