Skip to content

Remove archived prettier repo from pre-commit#374

Merged
jbampton merged 3 commits intoNextCommunity:mainfrom
jbampton:remove-pre-commit-prettier
Mar 20, 2026
Merged

Remove archived prettier repo from pre-commit#374
jbampton merged 3 commits intoNextCommunity:mainfrom
jbampton:remove-pre-commit-prettier

Conversation

@jbampton
Copy link
Member

No description provided.

@jbampton jbampton self-assigned this Mar 20, 2026
@jbampton jbampton added the chore label Mar 20, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the project's pre-commit hook configuration by removing an entry for an archived Prettier repository. This action simplifies the development environment setup and ensures that only actively maintained or relevant code quality tools are enforced before commits.

Highlights

  • Pre-commit Configuration Update: Removed the configuration for the mirrors-prettier repository and its associated prettier hook from the .pre-commit-config.yaml file. This change streamlines the pre-commit setup by removing an archived or no longer used tool.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jbampton jbampton added the pre_commit Pull requests that update pre_commit code label Mar 20, 2026
@jbampton jbampton added this to Next Mar 20, 2026
@jbampton jbampton moved this to Review in progress in Next Mar 20, 2026
@jbampton jbampton added this to the Hackfest milestone Mar 20, 2026
@deepsource-io
Copy link

deepsource-io bot commented Mar 20, 2026

DeepSource Code Review

We reviewed changes in 5cddac8...27ad684 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade  

Focus Area: Reliability
Security  

Reliability  

Complexity  

Hygiene  

Feedback

  • Uncontrolled global scope
    • Multiple scripts create or reuse top-level variables, causing implicit globals, collisions and shadowing; the codebase should enable strict mode and use let/const inside functions or modules to stop leaks.
  • Inconsistent declaration patterns
    • Mixing implicit assignments with var/let/const and repeated declarations produces shadowing and duplicate bindings; the code should standardize on block-scoped declarations and remove redundant redeclarations.
  • No module or encapsulation boundary
    • Files share the same namespace so unrelated code interferes across scripts; the project should isolate state with ES modules, IIFEs, or a single explicit namespace object to prevent cross-file conflicts.

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Mar 20, 2026 3:49p.m. Review ↗
Secrets Mar 20, 2026 3:49p.m. Review ↗

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the pre-commit hook for Prettier that was using an archived repository. While removing the dependency on an archived repository is a good practice, this change also removes code formatting enforcement for several file types (CSS, HTML, JavaScript, Markdown, YAML) without providing a replacement. I've suggested replacing the old hook with one that points directly to the official Prettier repository to ensure code formatting standards are maintained.

I am having trouble creating individual review comments. Click here to see my feedback.

.pre-commit-config.yaml (124-130)

high

Removing the hook for the archived pre-commit/mirrors-prettier repository is a good step. However, this completely removes the Prettier formatting step for CSS, HTML, JavaScript, Markdown, and YAML files, which can lead to inconsistent code style. I recommend replacing it with a hook that points directly to the official Prettier repository. This approach avoids using mirrors and lets you pin the Prettier version with rev.

  - repo: https://github.com/prettier/prettier
    rev: '3.3.2'
    hooks:
      - id: prettier
        name: run prettier
        entry: prettier
        language: node
        args: ['--write']
        types_or: [css, html, javascript, json, markdown, yaml]

{ fontSize: "50px" },
);
scene.physics.add.existing(player);
player = this.add.text(window.innerWidth / 2, window.innerHeight - 80, "🚀", {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable `player` is assigned without declaration, creating an implicit global


The variable player is assigned without being declared with let, const, or var. This creates an implicit global variable, which can lead to name collisions, makes code harder to maintain, and would throw an error in strict mode. This issue also applies to bullets, aliens, and cursors within the same function.

To fix this, explicitly declare these variables in the appropriate shared scope, likely at the top of the file, using let player, bullets, aliens, cursors;.

@jbampton jbampton merged commit 713b51a into NextCommunity:main Mar 20, 2026
5 of 7 checks passed
@jbampton jbampton deleted the remove-pre-commit-prettier branch March 20, 2026 15:58
@github-project-automation github-project-automation bot moved this from Review in progress to Done in Next Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore pre_commit Pull requests that update pre_commit code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant