Security: Undefined Variable next Referenced in Route Error Handler#5460
Open
barttran2k wants to merge 1 commit intoNginxProxyManager:developfrom
Conversation
The GET /schema route handler's function signature is `(req, res)` (only two parameters), but the catch block calls `next(err)`. Since `next` is not defined in this scope, this will throw a `ReferenceError` at runtime when an error occurs, potentially crashing the process or causing an unhandled rejection instead of properly returning an error response. Affected files: schema.js Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
|
Docker Image for build 1 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GET /schema route handler's function signature is
(req, res)(only two parameters), but the catch block callsnext(err). Sincenextis not defined in this scope, this will throw aReferenceErrorat runtime when an error occurs, potentially crashing the process or causing an unhandled rejection instead of properly returning an error response.Severity:
highFile:
backend/routes/schema.jsSolution
Add
nextas the third parameter to the route handler:.get(async (req, res, next) => {, or handle the error directly withres.status(500).send(...)in the catch block.Changes
backend/routes/schema.js(modified)Testing