fix: production polish — 12 UI, calculation, and schema fixes#7
Merged
NimbleEngineer21 merged 2 commits intomainfrom Mar 5, 2026
Merged
fix: production polish — 12 UI, calculation, and schema fixes#7NimbleEngineer21 merged 2 commits intomainfrom
NimbleEngineer21 merged 2 commits intomainfrom
Conversation
- Fix ko-fi button alignment, import column spacing, sticky table header - Remove clock from header; move status dot to refresh button with 30-min stale indicator (green → amber) - Swap sell/purchase date order for chronological flow - Clamp past expenses/paychecks to today (fixes "4 months" overcounting) - Schema v3→v6: empty default platform fees with auto-populate on import, spouse paycheck support, per-asset/retirement liquidation percentage - Add Liq % column and capital sales rows to Dashboard table - Add spouse paycheck UI to wizard, projections, and dashboard cards - Add investments step to setup wizard with ticker auto-detection - Stagger timeline marker labels above/below to prevent overlap
…verage
- Fix ReadinessTimeline stagger logic: replace .map() with for loop to
avoid referencing the array being constructed (TypeError on close markers)
- Fix frozen staleness indicator: replace module-level Date.now() with
useSyncExternalStore backed by a 60s interval so it stays live in SPA
- Fix v4→v5 migration: create cashFlow from {} when missing so spouse
fields are always added
- Fix v5→v6 migration: initialize assets to [] when not an array so
liquidationPercent migration always runs
- Update Roth comment to reflect partial liquidation semantics
- Add 22 new tests: calcCashFlow, retirement/asset liquidationPercent,
spouse income in calcMonthlySavings, schema migrations v3→v4/v4→v5/v5→v6,
and full v1→v6 end-to-end migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan