fix: resolve iconv error by switching to mb#4
Merged
bpajor merged 1 commit intopatched-2024from Feb 5, 2025
Merged
Conversation
bpajor
force-pushed
the
mb_utf32_conversion_instead_of_iconv
branch
from
786eb09 to
b2f4b83
Compare
bpajor
force-pushed
the
mb_utf32_conversion_instead_of_iconv
branch
from
b2f4b83 to
83ddf98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
iconvfunction is causing some errors and appears to be slower. We can usemb_convert_encodinginstead.