Setup pubkey on nlx server on test start by matislovas · Pull Request #1696 · NordSecurity/libtelio

matislovas · 2026-03-02T13:20:17Z

Problem

There was some crashes (or race condition) in natlab, when nordvpnlite tests was running first, and nlx server is not prepared by other tests before.

Solution

Prepare nlx server before running all tests.

☑️ Definition of Done checklist

Commit history is clean (requirements)
README.md is updated
Functionality is covered by unit or integration tests

gytsto

looks good, just want to see pipeline green before approving

Signed-off-by: Matas Misiunas <matislovas@gmail.com>

stalowyjez · 2026-03-03T16:37:07Z


    async def wait_till_ready(self) -> None:
        await self._server_ready_event.wait()
+        await asyncio.sleep(2.0)


What is this random sleep xd

Without this, tests fails, upnp -c trigerred too fast.

Signed-off-by: Matas Misiunas <matislovas@gmail.com>

gytsto

+2

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from ff8bf47 to 1afabc0 Compare March 2, 2026 13:44

matislovas temporarily deployed to Internal March 2, 2026 13:44 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 1afabc0 to 0690704 Compare March 2, 2026 13:48

matislovas temporarily deployed to Internal March 2, 2026 13:48 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 0690704 to 751c3e2 Compare March 2, 2026 14:06

matislovas temporarily deployed to Internal March 2, 2026 14:06 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 751c3e2 to 323fef3 Compare March 2, 2026 14:15

matislovas temporarily deployed to Internal March 2, 2026 14:15 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 323fef3 to 5cb97d2 Compare March 2, 2026 14:17

matislovas temporarily deployed to Internal March 2, 2026 14:17 — with GitHub Actions Inactive

matislovas changed the title ~~Do not try to setup pubkey on nlx server~~ Setup pubkey on nlx server Mar 2, 2026

matislovas changed the title ~~Setup pubkey on nlx server~~ Setup pubkey on nlx server on test start Mar 2, 2026

gytsto reviewed Mar 2, 2026

View reviewed changes

Comment thread nat-lab/tests/config.py Outdated

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 5cb97d2 to b757906 Compare March 2, 2026 16:32

matislovas temporarily deployed to Internal March 2, 2026 16:32 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from b757906 to 05a98c5 Compare March 3, 2026 07:32

matislovas temporarily deployed to Internal March 3, 2026 07:32 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 05a98c5 to 63e3608 Compare March 3, 2026 07:53

matislovas temporarily deployed to Internal March 3, 2026 07:54 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 63e3608 to d5e9f2b Compare March 3, 2026 07:59

matislovas temporarily deployed to Internal March 3, 2026 07:59 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from d5e9f2b to 477d370 Compare March 3, 2026 08:01

matislovas temporarily deployed to Internal March 3, 2026 08:01 — with GitHub Actions Inactive

Add error printing, when cross ping check fails

27bb737

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 477d370 to 5e8c8d6 Compare March 3, 2026 09:38

matislovas temporarily deployed to Internal March 3, 2026 09:38 — with GitHub Actions Inactive

matislovas temporarily deployed to Internal March 3, 2026 11:39 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 50dad14 to 353fd38 Compare March 3, 2026 12:50

matislovas temporarily deployed to Internal March 3, 2026 12:50 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 353fd38 to 643e785 Compare March 3, 2026 12:57

Add delay after opening multicast server

adc134b

Signed-off-by: Matas Misiunas <matislovas@gmail.com>

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 643e785 to 3349b79 Compare March 3, 2026 12:58

matislovas temporarily deployed to Internal March 3, 2026 12:59 — with GitHub Actions Inactive

matislovas marked this pull request as ready for review March 3, 2026 13:16

matislovas requested a review from a team as a code owner March 3, 2026 13:16

matislovas temporarily deployed to Internal March 3, 2026 15:31 — with GitHub Actions Inactive

stalowyjez reviewed Mar 3, 2026

View reviewed changes

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 42be7be to 644740c Compare March 4, 2026 07:02

matislovas temporarily deployed to Internal March 4, 2026 07:02 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 644740c to 6021ca7 Compare March 4, 2026 08:05

matislovas temporarily deployed to Internal March 4, 2026 08:05 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 6021ca7 to 22e6ebf Compare March 4, 2026 09:15

matislovas temporarily deployed to Internal March 4, 2026 09:15 — with GitHub Actions Inactive

stalowyjez reviewed Mar 4, 2026

View reviewed changes

Comment thread clis/nordvpnlite/src/core_api.rs Outdated

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 22e6ebf to 2449286 Compare March 4, 2026 10:05

matislovas temporarily deployed to Internal March 4, 2026 10:05 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 2449286 to 12c3e6d Compare March 4, 2026 11:36

matislovas temporarily deployed to Internal March 4, 2026 11:36 — with GitHub Actions Inactive

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 12c3e6d to 5dee977 Compare March 4, 2026 12:16

matislovas temporarily deployed to Internal March 4, 2026 12:16 — with GitHub Actions Inactive

Do not try to setup pubkey on nlx server

05efc0f

Signed-off-by: Matas Misiunas <matislovas@gmail.com>

matislovas force-pushed the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch from 5dee977 to 05efc0f Compare March 4, 2026 13:11

matislovas temporarily deployed to Internal March 4, 2026 13:11 — with GitHub Actions Inactive

gytsto approved these changes Mar 4, 2026

View reviewed changes

matislovas added this pull request to the merge queue Mar 4, 2026

Merged via the queue into main with commit a08bf39 Mar 4, 2026
58 checks passed

matislovas deleted the matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server branch March 4, 2026 17:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup pubkey on nlx server on test start#1696

Setup pubkey on nlx server on test start#1696
matislovas merged 3 commits intomainfrom
matislovas/natlab_fix_nordvpnlite_tests_setup_vpn_server

matislovas commented Mar 2, 2026 •

edited

Loading

Uh oh!

gytsto left a comment

Uh oh!

Uh oh!

stalowyjez Mar 3, 2026

Uh oh!

matislovas Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gytsto left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

matislovas commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

☑️ Definition of Done checklist

Uh oh!

gytsto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stalowyjez Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

matislovas Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gytsto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

matislovas commented Mar 2, 2026 •

edited

Loading