Skip to content

Added LAN8670_Read_PHY_ID1() and LAN8670_Read_Model_Number() to LAN8670 PHY Driver#370

Merged
bjackson312006 merged 1 commit intomainfrom
feature/phy-id-registers
Feb 17, 2026
Merged

Added LAN8670_Read_PHY_ID1() and LAN8670_Read_Model_Number() to LAN8670 PHY Driver#370
bjackson312006 merged 1 commit intomainfrom
feature/phy-id-registers

Conversation

@bjackson312006
Copy link
Contributor

Added LAN8670_Read_PHY_ID1() and LAN8670_Read_Model_Number() to the LAN8670 PHY driver. These functions should be helpful for debugging, since these register fields have known values.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds two new debugging helper functions to the LAN8670 PHY driver that read hardware identification registers with known values, making it easier to verify proper communication with the device.

Changes:

  • Added LAN8670_Read_PHY_ID1() to read the 16-bit PHY Identifier 1 register containing the first half of the OUI (expected value: 0x0007)
  • Added LAN8670_Read_Model_Number() to read the 6-bit model number field from the PHY Identifier 2 register (expected value: 0x16 for LAN8670)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
general/src/lan8670.c Implements the two new register read functions with proper error handling following established patterns
general/include/lan8670.h Declares the new functions with Doxygen documentation describing their purpose and expected values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will figure out why clang format is failing

@bjackson312006 bjackson312006 merged commit ddcea9a into main Feb 17, 2026
7 of 8 checks passed
@bjackson312006 bjackson312006 deleted the feature/phy-id-registers branch February 17, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants