Fix schema-qualified table names for PostgreSQL#45
Open
montanalow wants to merge 1 commit intoNyxCode:masterfrom
Open
Fix schema-qualified table names for PostgreSQL#45montanalow wants to merge 1 commit intoNyxCode:masterfrom
montanalow wants to merge 1 commit intoNyxCode:masterfrom
Conversation
Previously, a table name like `schema.table` would be quoted as
`"schema.table"`, which PostgreSQL interprets as a single identifier
containing a literal dot character.
This change splits the table name on `.` and quotes each part
separately, producing `"schema"."table"` which PostgreSQL correctly
interprets as schema + table.
This allows using schema-qualified table names in the `#[ormx(table = ...)]`
attribute, e.g.:
```rust
#[derive(ormx::Table)]
#[ormx(table = "my_schema.users", id = id)]
struct User { ... }
```
Added an example demonstrating schema-qualified table usage with `app.products`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where schema-qualified table names (e.g.,
schema.table) were being incorrectly quoted in generated SQL.The Problem
When using a table name like
yahoo.exchanges:The generated SQL would quote the entire name as
"yahoo.exchanges", which PostgreSQL interprets as a single identifier containing a literal dot character. This causes errors like:The Fix
The
name()method now splits the table name on.and quotes each part separately, producing"yahoo"."exchanges"which PostgreSQL correctly interprets as schema + table.Testing
example-postgresthat creates anappschema with aproductstable#[ormx(table = "app.products", ...)]