[19.0][MIG] product #5477
Open
[19.0][MIG] product #5477
+347
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/ocabot migration product |
hbrunn
force-pushed
the
19.0-initialize+openupgrade_framework+base+uom+mail+product
branch
from
44a5d66 to
7882bd2
Compare
hbrunn
force-pushed
the
19.0-initialize+openupgrade_framework+base+uom+mail+product
branch
2 times, most recently
from
9366c47 to
7a9d1a8
Compare
hbrunn
force-pushed
the
19.0-initialize+openupgrade_framework+base+uom+mail+product
branch
from
7a9d1a8 to
4fa5139
Compare
Comment on lines
+73
to
+75
| FROM product_product, product_template | ||
| WHERE | ||
| product_supplierinfo.product_id=product_product.id |
Contributor
There was a problem hiding this comment.
Suggested change
| FROM product_product, product_template | |
| WHERE | |
| product_supplierinfo.product_id=product_product.id | |
| FROM product_template | |
| WHERE | |
| product_supplierinfo.product_id IS NOT NULL |
| Rename product_packaging here to product_uom, and amend with data in post-migration | ||
| Set uom_id to dummy UOM to have the ORM set up the not null constraint correctly | ||
| """ | ||
| openupgrade.rename_tables(env.cr, [("product_packaging", "product_uom")]) |
Contributor
There was a problem hiding this comment.
call rename_models too.
| # NOTHING TO DO: virtual field only used for searching | ||
|
|
||
| product / product.product / packaging_ids (one2many) : DEL relation: product.packaging | ||
| product / product.product / product_uom_ids (one2many) : NEW relation: product.uom |
Contributor
There was a problem hiding this comment.
why not rename fields too?
| openupgrade.delete_records_safely_by_xml_id( | ||
| env, | ||
| [ | ||
| "product.constraint_product_packaging_positive_qty", |
Contributor
There was a problem hiding this comment.
better delete constraints with delete_sql_constraint_safely.
| NEW product.category: product.product_category_services (noupdate) | ||
| DEL product.category: product.cat_expense (noupdate) | ||
| DEL product.category: product.product_category_1 (noupdate) | ||
| DEL product.category: product.product_category_all (noupdate) |
Contributor
There was a problem hiding this comment.
safely remove this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends: