Conversation
bosd
force-pushed
the
19.0-mig-product_contract
branch
2 times, most recently
from
663c231 to
be0367d
Compare
|
/ocabot migration product_contract |
|
Sorry @bosd you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
bosd
force-pushed
the
19.0-mig-product_contract
branch
4 times, most recently
from
53f361e to
3600f5d
Compare
|
/ocabot migration product_contract @bosd I see that you have generated |
Yeah, I noticed that the custom script i used, created this.. |
|
Uhm, I don't think it's OK, as now it's even more confusing about its source. I would prefer to let them as it was than this way. |
* Add contract functionality to `product.templates` * Add logic to create contracts from `sale.order` that contains contract products.
* Change the method called in the view * Complete the create_invoice method * Bump version + authoring * Correct bad call of method Small Documentation * Add super call in python test * FIX bad field names causing bad quantities in sale.order.line
- On Sale Order confirmation, a contract is created for each contract template used on sale order lines - A not finished contract can be mentioned on sale order line - A sale order line linked to a contract will update it and don't create a new one if it had the same template
recurring_next_date should be computed by contract line to get default value
- Sale order line for contract product pass to nothing to invoice on order confirmation - Contract Invoices are linked to sale order line
…ree not editable Before this changes, when trying to edit a line of sale order, it was opening the form of the line. But following the way to work of odoo with sale event, we have make a new contract configurator that will be opened when selecting a product of type contract.
…using confirmation date_start With these changes, we allow the contract line start date to be computed using the order confirmation date. When the product is configured with any of the options set in contract_start_date_method other than manual, the start date will be calculated based on the established date and the selected period. Additionally, we can force the month in which we will work in case the frequency is yearly, quarterly, or semesterly. Is not added support for daily, weekly or monthlylastday in this commit.
…ttings [IMP] product_contract: add Recurrence Number to compute start and end dates [FIX] product_contract: add sol name dependes [IMP] product_contract: add recurrence interval [IMP] product_contract: add recurring_interval
…d to recurrence_number for more clarity rename default_qty to recurrence_number
…ack a contract template Before this commit, confirming a sales order would raise an exception if any line lacked a configured contract template, preventing the creation of the contract. Now, sales order lines without a contract template are automatically added to a new contract without a template, allowing the process to continue seamlessly.
bosd
force-pushed
the
19.0-mig-product_contract
branch
from
3600f5d to
53cde28
Compare
|
It is ok now |
bosd
force-pushed
the
19.0-mig-product_contract
branch
from
53cde28 to
321af49
Compare
bosd
force-pushed
the
19.0-mig-product_contract
branch
from
670735b to
bcf1c24
Compare
|
Hey @bosd, I found this issue raulovallet@67bfd99. It causes the default values not to be set correctly and throws an error when closing the window. I’m not sure how I can contribute—could you make a cherry-pick or I have to do a pull request here? |
…perties instead of array indices Cherry-picked from raulovallet/contract@67bfd99
|
Hi @bosd , I am facing an issue here with this module - the required="is_contract" on date_start seems to be wrong. In state draft,sent there must not be a date_start specified. Why is this required ? |
|
Hi @bosd , Please ignore my last comment - i found the real issue... I have been working on an migrated database (migrated from v16) - i had sale.order.line's with contract_start_date_method='manual' and date_start=null For the record - i've fixed it with: UPDATE sale_order_line sol
SET date_start = COALESCE(
(SELECT cl.date_start FROM contract_line cl
WHERE cl.sale_order_line_id = sol.id AND cl.date_start IS NOT NULL LIMIT 1),
(SELECT so.date_order::date FROM sale_order so WHERE so.id = sol.order_id),
sol.create_date::date
)
FROM product_product pp
JOIN product_template pt ON pt.id = pp.product_tmpl_id
WHERE sol.product_id = pp.id
AND pt.is_contract IS TRUE
AND sol.date_start IS NULL
AND COALESCE(sol.contract_start_date_method, 'manual') = 'manual'; |
20 participants
Standard migration using odoo-module-migrator .
This version is severly cleaned according to:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
Total reduction from 202 to 105 commits (44% reduction)
Also lists the depends properly.
depends on:
#1312
#1367
#1370