Skip to content

[18.0][FIX] report_xlsx: report xlsx/xlrd 2.0 compatibility#1081

Merged
OCA-git-bot merged 2 commits intoOCA:18.0from
xcgd:bugfix/18.0/report_xlsx/xlrd-2.0-compatibility
Apr 15, 2026
Merged

[18.0][FIX] report_xlsx: report xlsx/xlrd 2.0 compatibility#1081
OCA-git-bot merged 2 commits intoOCA:18.0from
xcgd:bugfix/18.0/report_xlsx/xlrd-2.0-compatibility

Conversation

@vincent-hatakeyama
Copy link
Copy Markdown
Contributor

  • Removed the module requirements, they are already required libraries of odoo
  • Adapt the tests to avoid failing when xlrd is at version 2.0 (the library does not handle xlsx): use openxyl by default and fall back on using xlrd if the version is compatible.

I’ve added a skip of the tests if both library are absent; not sure it should stay.

@vincent-hatakeyama vincent-hatakeyama force-pushed the bugfix/18.0/report_xlsx/xlrd-2.0-compatibility branch from 9575715 to e4be74c Compare October 21, 2025 09:40
@vincent-hatakeyama
Copy link
Copy Markdown
Contributor Author

In #1078, the use of xlrd has been completely removed in favour of openpyxl. The same could be done here.

@lmignon
Copy link
Copy Markdown
Contributor

lmignon commented Apr 15, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1081-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 15, 2026
Signed-off-by lmignon
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Copy Markdown
Contributor

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-1081-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3f58cb4 into OCA:18.0 Apr 15, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 45bc3b3. Thanks a lot for contributing to OCA. ❤️

@vincent-hatakeyama vincent-hatakeyama deleted the bugfix/18.0/report_xlsx/xlrd-2.0-compatibility branch April 15, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants