[17.0][FIX] auth_signup_verify_email: ignore captcha fields in passwordless signup#901
Open
jdma-eledia wants to merge 1 commit intoOCA:17.0from
Open
[17.0][FIX] auth_signup_verify_email: ignore captcha fields in passwordless signup#901jdma-eledia wants to merge 1 commit intoOCA:17.0from
jdma-eledia wants to merge 1 commit intoOCA:17.0from
Conversation
baea655 to
8c34ad8
Compare
8c34ad8 to
9bf3b66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When passwordless signup is used, the controller forwards raw request parameters to res.users.signup().
If captcha modules are enabled (Cloudflare Turnstile / reCAPTCHA), extra POST fields such as
turnstile_captcha and recaptcha_token_response are present and get passed to user creation.
This causes signup to crash with:
SignupError: Invalid field 'turnstile_captcha' on model 'res.users'
Root cause
passwordless_signup() was using request.params directly and only removed redirect and token,
leaving captcha/transient fields in values.
Fix
exists on ir.http (to avoid hard dependency regressions when captcha addon is not installed).
Tests
Added a regression test that posts captcha fields together with a valid signup email and
verifies the passwordless signup still succeeds.
Impact