[18.0][MIG] base_user_effective_permissions: Migration to 18.0 by BhaveshHeliconia · Pull Request #354 · OCA/server-backend

BhaveshHeliconia · 2025-04-28T10:17:49Z

No description provided.

github-actions · 2025-11-23T12:21:45Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Currently translated at 100.0% (26 of 26 strings) Translation: server-backend-16.0/server-backend-16.0-base_user_effective_permissions Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_user_effective_permissions/it/

BhaveshHeliconia · 2025-11-25T07:04:37Z

Hey @OCA/tools-maintainers would be great if someone could have a look at this module.

legalsylvain · 2025-11-25T08:57:17Z

@hbrunn : could you take a look on this migration ?

hbrunn

/ocabot migration base_user_effective_permissions

hbrunn · 2025-11-25T09:45:58Z

+                    vals[f"{operation}_permission"] = True
+                except Exception:
+                    vals[f"{operation}_permission"] = False
+                try:


under which conditions is this expected to raise? I'd expect something to be very wrong when this happens, and then we shouldn't squelch the exception

you didn't answer this question

The _compute_domain() method can raise an AccessError when:

The user doesn't have access to certain ir.rule records

Domain evaluation fails due to missing fields or invalid domain syntax

Security restrictions prevent domain computation for specific models

In these cases, setting an empty domain "[]" is appropriate as it indicates no domain-based restrictions beyond the basic access rights check already performed by ir.model.access#check.
However, you're right that we shouldn't squelch all exceptions. I'll update the code to catch only AccessError

obvious copy&paste from coding assistant, no interest to continue discussion

@hbrunn here I accept that I used AI but its only to clean up the wording, since sometimes I struggle to words things well. Sorry if that caused any confusion.
Next onwards I will try to best to answer well.

@hbrunn From my side I would say that this comment is addressed by catching only AccessError?

it's nonsense to catch any error here

to better mimic what Odoo does this could however not call _compute_domain at all if vals[f"{operation}_permission"] is False, and do all of this in the same loop anyways

BhaveshHeliconia · 2025-11-26T04:21:51Z

@hbrunn : I’ve made the changes as per your suggestion. Could you please review? Thanks!”

hbrunn

thanks for sanitizing the loop. remaining issue is that the domain widget crashes on some permission records, I suspect you need to filter out cases where model._abstract is True

BhaveshHeliconia · 2026-03-09T08:34:24Z

thanks for sanitizing the loop. remaining issue is that the domain widget crashes on some permission records, I suspect you need to filter out cases where model._abstract is True

Thanks for pointing this out. Please have another look when you get a chance.

yvaucher · 2026-03-13T17:07:38Z

/ocabot merge nobump

OCA-git-bot · 2026-03-13T17:07:47Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-354-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-13T17:12:42Z

Congratulations, your PR was merged at 4e0e191. Thanks a lot for contributing to OCA. ❤️

BhaveshHeliconia mentioned this pull request Apr 28, 2025

Migration to version 18.0 #312

Open

14 tasks

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch 2 times, most recently from e61b84b to d35c607 Compare April 29, 2025 07:11

BhaveshHeliconia closed this Apr 29, 2025

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from d35c607 to aedf873 Compare April 29, 2025 10:33

BhaveshHeliconia reopened this Apr 29, 2025

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from aedf873 to ab6a1ae Compare July 25, 2025 06:57

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 23, 2025

hbrunn and others added 3 commits November 25, 2025 11:58

[ADD] base_user_effective_permissions

a973fbf

Added translation using Weblate (Italian)

a03d210

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from ab6a1ae to 11a0a46 Compare November 25, 2025 06:28

hbrunn requested changes Nov 25, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Nov 25, 2025

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from 11a0a46 to 1f9939e Compare November 26, 2025 04:19

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from 1f9939e to 2e88e57 Compare November 26, 2025 10:49

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 30, 2025

yvaucher requested changes Feb 25, 2026

View reviewed changes

Comment thread base_user_effective_permissions/= Outdated

yvaucher and others added 2 commits February 26, 2026 09:49

Remove artifact file of manifest

c7e0719

[IMP] base_user_effective_permissions: pre-commit auto fixes

1b93836

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from 2e88e57 to 22f01e9 Compare February 26, 2026 04:21

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from 22f01e9 to e0fe679 Compare March 6, 2026 08:13

hbrunn requested changes Mar 7, 2026

View reviewed changes

[MIG] base_user_effective_permissions: Migration to 18.0

910fbd2

BhaveshHeliconia force-pushed the 18.0-mig-base_user_effective_permissions branch from e0fe679 to 910fbd2 Compare March 9, 2026 08:16

BhaveshHeliconia requested a review from hbrunn March 13, 2026 03:02

hbrunn approved these changes Mar 13, 2026

View reviewed changes

hbrunn requested a review from yvaucher March 13, 2026 14:59

yvaucher approved these changes Mar 13, 2026

View reviewed changes

OCA-git-bot added the approved label Mar 13, 2026

OCA-git-bot added the bot is merging ⏳ label Mar 13, 2026

OCA-git-bot merged commit 4875900 into OCA:18.0 Mar 13, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 13, 2026

Uh oh!

Conversation

BhaveshHeliconia commented Apr 28, 2025

Uh oh!

github-actions Bot commented Nov 23, 2025

Uh oh!

BhaveshHeliconia commented Nov 25, 2025

Uh oh!

legalsylvain commented Nov 25, 2025

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Nov 26, 2025

Uh oh!

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Mar 9, 2026

Uh oh!

yvaucher commented Mar 13, 2026

Uh oh!

OCA-git-bot commented Mar 13, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants