Skip to content

[16.0][ADD] base_external_system_odoorpc#411

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
Therp:16.0-add-base_external_system_odoorpc
Mar 30, 2026
Merged

[16.0][ADD] base_external_system_odoorpc#411
OCA-git-bot merged 1 commit intoOCA:16.0from
Therp:16.0-add-base_external_system_odoorpc

Conversation

@ntsirintanis
Copy link
Copy Markdown
Contributor

This module adds an external system adapter for connecting to another Odoo instance
using the Python odoorpc client (JSON-RPC).

It is built on top of base_external_system and implements a new adapter model:

  • external.system.odoo (System Type: External System RPC)

The adapter supports:

  • Validating required connection parameters (host, port, database, username, password)
  • Optional SSL transport (JSON-RPC over SSL)
  • A context-managed client lifecycle via the base_external_system adapter contract
    (open client, perform calls, logout/cleanup)

@ntsirintanis
Copy link
Copy Markdown
Contributor Author

@thomaspaulb @NL66278

Copy link
Copy Markdown
Member

@Kiplangatdan Kiplangatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested on v16.0 CE.

A minor suggestion to consider checking for base.user_admin instead of the login=admin

Comment thread base_external_system_odoorpc/models/external_system_odoo.py Outdated
@ntsirintanis ntsirintanis force-pushed the 16.0-add-base_external_system_odoorpc branch from bb3536c to 1a7a65e Compare March 26, 2026 13:39
sys.id,
)

def test_external_get_clien_ssl(self):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A spelling mistake: client is missing the final t.

Copy link
Copy Markdown
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. One minor remark on name of test method (does not influence actual test).

@ntsirintanis ntsirintanis force-pushed the 16.0-add-base_external_system_odoorpc branch from 1a7a65e to 30ac90b Compare March 30, 2026 08:29
@thomaspaulb
Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-411-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 93f6049 into OCA:16.0 Mar 30, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4c2d789. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants