[16.0][IMP] session_db: Modify the way to parse data from session data#3497
Open
JonathanOsAlc wants to merge 1 commit intoOCA:16.0from
Open
[16.0][IMP] session_db: Modify the way to parse data from session data#3497JonathanOsAlc wants to merge 1 commit intoOCA:16.0from
JonathanOsAlc wants to merge 1 commit intoOCA:16.0from
Conversation
Contributor
|
Hi @sbidoul, |
- Add a way to detect the binary values to parse as strings when
saving the session to the database.
- To identify the data that was converted from binary to str,
add a prefix base64:: to the string.
- Then, when the session needs to be read, detect the values
modified, and parse again to base64.
- Verify if some value of the session is a monetary value and parse
it to a float type.
- Keep string type in the value of the 'debug' website parameter.
5c49968 to
3c70bb6
Compare
Member
|
Hello and thanks for contributing! To help me understand your PR, can you elaborate the problem you are addressing? In particular do they also occur with the standard Odoo session or only with session_db? Do they occur with standard Odoo modules or custom code? Can you also elaborate what the problem with debug=1, as I personally never noticed any problem in debug mode with session_db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behaviour before PR:
URL?debug=1Desired behavior after PR is merged: