Skip to content

[19.0][MIG] website_google_tag_manager: Migration to 19.0#1131

Merged
OCA-git-bot merged 35 commits intoOCA:19.0from
adhoc-dev:19.0-mig-website_google_tag_manager
Apr 6, 2026
Merged

[19.0][MIG] website_google_tag_manager: Migration to 19.0#1131
OCA-git-bot merged 35 commits intoOCA:19.0from
adhoc-dev:19.0-mig-website_google_tag_manager

Conversation

@JrAdhoc
Copy link
Copy Markdown
Contributor

@JrAdhoc JrAdhoc commented Oct 8, 2025

No description provided.

sebalix and others added 30 commits October 8, 2025 12:41
* [ADD] New module 'website_google_tag_manager'

* [FIX] website_google_tag_manager - Added OCA as author

* [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager')

* [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/fr/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-12.0/website-12.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/pt_BR/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-14.0/website-14.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/es_AR/
Currently translated at 72.7% (8 of 11 strings)

Translation: website-14.0/website-14.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/fr_FR/
Currently translated at 12.5% (1 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/es/
Currently translated at 100.0% (8 of 8 strings)

Translation: website-16.0/website-16.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: website-17.0/website-17.0-website_google_tag_manager
Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_google_tag_manager/
…anager

Adding script before the wrapwrap element affects style [1] and hide the
nav bar behind of the main menu, so it is required adding it after the
wrapwrap element, the same way as [2] does it.

Reference:

- [1] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/static/src/scss/website.scss#L200
- [2] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/views/website_templates.xml#L151
Copilot AI review requested due to automatic review settings October 8, 2025 16:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the website_google_tag_manager module from Odoo 18.0 to 19.0. The migration involves updating the manifest version, adjusting template inheritance, and maintaining compatibility with the new Odoo version while preserving all existing functionality for Google Tag Manager integration.

  • Updated module version from 18.0.1.0.0 to 19.0.1.0.0 in the manifest
  • Modified template positioning to use a more robust XPath selector for the body element
  • Maintained all existing Google Tag Manager functionality and configuration options

Reviewed Changes

Copilot reviewed 71 out of 73 changed files in this pull request and generated no comments.

File Description
website_google_tag_manager/manifest.py Updated version to 19.0.1.0.0 for Odoo 19.0 compatibility
website_google_tag_manager/views/website_templates.xml Modified XPath selector for template inheritance positioning
All other files New files added as part of the complete module structure for 19.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JrAdhoc JrAdhoc mentioned this pull request Oct 8, 2025
10 tasks
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@atchuthan
Copy link
Copy Markdown
Member

@OCA/website-maintainers This PR is ready for merge.

@ALopez-Adhoc
Copy link
Copy Markdown

lgtm

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 22, 2026
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration website_google_tag_manager
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Apr 6, 2026
@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-1131-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 72c3342 into OCA:19.0 Apr 6, 2026
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 870fdba. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.