Improvement: Replace gitleaks with detect-secrets & detect-private-key#235
Open
dombean wants to merge 1 commit intodevelopmentfrom
Open
Improvement: Replace gitleaks with detect-secrets & detect-private-key#235dombean wants to merge 1 commit intodevelopmentfrom
dombean wants to merge 1 commit intodevelopmentfrom
Conversation
49d3046 to
fd58e87
Compare
Replace gitleaks with detect-secrets & detect-private-key Replace gitleaks with detect-secrets & detect-private-key Replace gitleaks with detect-secrets & detect-private-key Replace gitleaks with detect-secrets & detect-private-key
7e37b58 to
a170708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced
gitleakswithdetect-secretsand addeddetect-private-keyfor secret scanning in pre-commit hooks.Developer tooling only, no impact on runtime or API.
Checklist:
Peer review
Any new code includes all the following:
Review comments
Suggestions should be tailored to the code that you are reviewing. Provide context.
Be critical and clear, but not mean. Ask questions and set actions.
These might include:
that it is likely to interact with?)
works correctly? Are there additional edge cases/ negative tests to be considered?
Further reading: code review best practices