Conversation
…lied to a subset. Also add testing files.
…able subset with the direct chunk IO.
…Compile but not test it yet.
…hod 2) Also add a line to update the direct IO offset for the chunks that cover subset for the direct IO.
…o the subset size case fall into the dio case.
…) Update fileout netCDF valgrind tests. 3) Add a python script to generate compact storage hdf5 file(not in the scope of this ticket. Since it is too small with a new ticket. Just attach with this ticket.)
|
|
|
dh-opendap
approved these changes
Feb 23, 2026
Contributor
dh-opendap
left a comment
dh-opendap
left a comment
There was a problem hiding this comment.
Good, looks cleaner with the addtional DIO storage_info and read methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference ticket: HYRAX-2015, HYRAX-2016, HYRAX-2019
Support the direct chunk IO with the good subset cases.
Tasks