Open
Conversation
Detach m_qwtPlotCurveForLegendText before the viewer check so it is always detached before deletion. Add null check for curves in detachPlotCurves, and explicitly call detachPlotCurves from RimWellLogTrack::detachAllPlotItems to ensure curves are detached before the track is destroyed.
… ensemble Add parameter.isNumeric() guard and bounds check in RimCorrelationMatrixPlot::createMatrix(). Text parameters deduplicate values into fewer entries than ensemble cases, causing out-of-bounds access. Add defensive bounds check in RimParameterResultCrossPlot::createCaseData() for consistency.
Replace CVF_ASSERT with bounds checks returning std::unexpected with descriptive error messages. Call site updated with TODO to propagate the error when the receiving system is ready.
Replace CVF_ASSERT with an early return guard to prevent crash when view is null or equals the master view. Also guard null pointer use in RicSetMasterViewFeature.
…n and missing null guard
magnesj
force-pushed
the
crash-fixes-open-telemetry
branch
from
91cfe6b to
2e1c262
Compare
magnesj
force-pushed
the
crash-fixes-open-telemetry
branch
from
c826af7 to
00ba5c3
Compare
…exception Uninitialized m_hdfFile caused a crash when the H5::H5File constructor threw an exception, as the catch block called delete on a garbage pointer.
…delete to fix race deleteChildrenAsync() spawns a std::thread that deletes old RimFileSummaryCase objects concurrently with the OpenMP parallel loop in loadFileSummaryCaseData(). #pragma omp critical only synchronizes OMP threads, not std::threads, so OPM/HDF5 library state was accessed simultaneously from both, causing crashes. Replace with clearWithoutDelete() + synchronous delete to preserve the observer signal disconnection fix from #12262 while eliminating the thread race.
…ynamic NNC transfer ecl_file_get_restart_view can return null when a timestep has no restart view, and the result was passed unchecked into ERT functions. Also added a null guard for grid and summaryView at the entry of transferNncFluxData to prevent a crash in ecl_nnc_geometry_alloc on null grid.
…step reads to fix crash Co-Authored-By: Magne Sjaastad <magne.sjaastad@yahoo.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13872
Closes #13874
Closes #13876
Closes #13877
Closes #13878
Closes #13881
Closes #13882
Closes #13883
Closes #13884
Closes #13885