Second PR: fix get_bids_metadata to handle missing keys and sequence errors#24

Open

srimajaya123-blip wants to merge 1 commit intoOSIPI:mainfrom

srimajaya123-blip:second-pr-package-fix

srimajaya123-blip commented Feb 28, 2026

This PR improves the get_bids_metadata function:

Handles cases where modality or dicom_dir are missing.
Raises a clear ValueError when no matching sequence is found.
Adds robust unit tests using mocks for DICOM headers and sequences.
Ensures all package tests pass without touching backend dependencies.

This improves developer experience and prevents unexpected crashes during package-only tests.


          Second PR: improve get_bids_metadata tests

428d0cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet