openssl >= 1.0.1 has SSL_OP_NO_SSLv2 == 0; fix unused-function warnin…

[crylico]

…g for pointed-to-only functions

[Midar]

Hm, this works for me with OpenSSL 1.0.2j. The #pragma part of the change seems like a hash, can you paste the actual error you get? There might be a better way to do this, depending on the error you get.

[crylico]

I'm using libcurl4-openssl-dev as my openssl implementation - Maybe they've diverged from the general OpenSSL releases?

As for the #pragma's, it only shows up under -Wall and is only a problem under -Werror. This is probably something that doesn't belong in the code now that I think about it.

Perhaps the change to the SSL flag checking is still good to assure correctness regardless of version?

[Midar]

libcurl4-openssl-dev sounds like you're using Debian? Which release exactly?

Yes, it's normal that it only shows up with -Wall and only is a problem with -Werror - but that is intentional. Since this is not 1.0 yet, I'd rather have people open bugs because it doesn't compile than warnings going unnoticed :). The bug sounds pretty similar to what I've seen on OpenSSL 1.1, though. I was thinking about maybe just adding some (void)foo to make the unused warning go away in that case.

[crylico]

Yep! I'm using Debian 8.7.

[Midar]

What does openssl version print for you?

[crylico]

OpenSSL 1.0.1t  3 May 2016 - Kyle

…

On Mar 25, 2017, 10:17 AM -0400, Jonathan Schleifer ***@***.***>, wrote: What does openssl version print for you? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.