Open
Conversation
tothegills
requested changes
May 6, 2024
Contributor
tothegills
left a comment
There was a problem hiding this comment.
Halibut doesn't know that Tentacle exists. We would need to provide the suggestion somewhere that is Tentacle-aware, probably in Octopus server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The errors around polling tentacles not connecting are vague and don't help the customer investigate issues that may arise. This PR adds a simple message to re-direct them to the tentacle logs to investigate, as there is no current way of writing the halibut exception from tentacle to the server/task logs.
Results
Relates to OctopusDeploy/Issues#8761
Pre-requisites