Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KolbyML
reviewed
Feb 26, 2026
Member
KolbyML
left a comment
KolbyML
left a comment
There was a problem hiding this comment.
Here are things that immediately standout on my first look, I am going to try and do a more thorough pass in a bit.
| The Stylus WASM VM uses a register-based execution model: | ||
|
|
||
| - **Operations**: Work with virtual registers and local variables | ||
| - **Instructions**: Thousands of WASM instructions with fine-grained metering |
Comment on lines
+154
to
+156
| ### WASM instructions | ||
|
|
||
| - **Count**: Hundreds of instructions |
Contributor
Author
There was a problem hiding this comment.
More hundreds...Corrected.
Comment on lines
+36
to
+40
| ### WASM: Register-based architecture | ||
|
|
||
| The Stylus WASM VM uses a register-based execution model: | ||
|
|
||
| - **Operations**: Work with virtual registers and local variables |
Member
There was a problem hiding this comment.
Isn't WASM a stack based architecture as well
Contributor
Author
There was a problem hiding this comment.
Thanks for flagging. Is the new version correct?
Co-authored-by: Pete <petevielhaber@gmail.com>
Co-authored-by: Pete <petevielhaber@gmail.com>
Co-authored-by: Pete <petevielhaber@gmail.com>
Co-authored-by: Pete <petevielhaber@gmail.com>
Co-authored-by: Pete <petevielhaber@gmail.com>
Co-authored-by: Pete <petevielhaber@gmail.com>
Co-authored-by: Pete <petevielhaber@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VM differences concept for Stylus v0.10 documentation.
This PR adds the VM differences concept guide from the alternate structure.