Delayed Sequencer delegates tx hash deletion to sequencer by MishkaRogachev · Pull Request #4346 · OffchainLabs/nitro

MishkaRogachev · 2026-02-06T17:26:50Z

Attention to the base branch.

codecov · 2026-02-06T17:43:44Z

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.70%. Comparing base (d0abe6b) to head (a49413e).
⚠️ Report is 532 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4346      +/-   ##
==========================================
+ Coverage   33.66%   34.70%   +1.03%     
==========================================
  Files         493      493              
  Lines       58290    58329      +39     
==========================================
+ Hits        19623    20242     +619     
+ Misses      35203    34513     -690     
- Partials     3464     3574     +110

github-actions · 2026-02-06T17:46:52Z

❌ 10 Tests Failed:

Tests completed	Failed	Passed	Skipped
4242	10	4232	0

View the top 3 failed tests by shortest run time

TestValidationInputsAtWithWasmTarget

Stack Traces | 4.910s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-02|10:40:41.752] Persisted trie from memory database      nodes=25  flushnodes=0 size=4.33KiB   flushsize=0.00B time="135.452µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=106 livesize=18.66KiB
INFO [03-02|10:40:41.754] Writing cached state to disk             block=1  hash=ffb0f6..f613ba root=caf4e6..fb08c8
INFO [03-02|10:40:41.754] Persisted trie from memory database      nodes=27  flushnodes=0 size=4.62KiB   flushsize=0.00B time="156.903µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=79  livesize=14.05KiB
INFO [03-02|10:40:41.754] Writing snapshot state to disk           root=8261c5..2e5bfb
INFO [03-02|10:40:41.754] Persisted trie from memory database      nodes=0   flushnodes=0 size=0.00B     flushsize=0.00B time=852ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=79  livesize=14.05KiB
INFO [03-02|10:40:41.754] Blockchain stopped
INFO [03-02|10:40:41.754] Persisted dirty state to disk            size=140.57KiB elapsed=84.276ms
INFO [03-02|10:40:41.755] Blockchain stopped
INFO [03-02|10:40:41.755] Reading message result remotely.         msgIdx=0
INFO [03-02|10:40:41.755] Ethereum protocol stopped
INFO [03-02|10:40:41.755] HTTP server stopped                      endpoint=127.0.0.1:45053
TRACE[03-02|10:40:41.755] P2P networking is spinning down
WARN [03-02|10:40:41.755] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [03-02|10:40:41.756] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
INFO [03-02|10:40:41.756] Submitted transaction                    hash=0xd6b2f7b4ae8cc31d6280020a477e8ac77c919b63f07cfd8039d3602054484f4d from=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23 nonce=5  recipient=0x5F45B98eAEF5b55Dc1f66F2C05d64C3Ae117BE14 value=0
INFO [03-02|10:40:41.756] Submitted transaction                    hash=0x1c251ce1bc116931863c2d1c7d42de48131e55cf3992f6baa5636ad1fdd93dd6 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=45 recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1
INFO [03-02|10:40:41.756] DataPoster sent transaction              nonce=5  hash=d6b2f7..484f4d feeCap=25,065,735,860 tipCap=50,000,000 blobFeeCap=&lt;nil&gt; gas=158,592
INFO [03-02|10:40:41.756] BatchPoster: batch sent                  sequenceNumber=6 from=10 to=13 prevDelayed=1 currentDelayed=1 totalSegments=5  numBlobs=0
INFO [03-02|10:40:41.756] Submitted transaction                    hash=0xa0fdbdd5ecd6d5371be37998fd5722f9c84dadb63c2ec23c7dc2f1efa6dee2bd from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=11 recipient=0x27cd9DDFf7a77DD9a8628522E2b49160A170FfD6 value=10,000,000,000,000,000
--- FAIL: TestValidationInputsAtWithWasmTarget (4.91s)

TestVersion40

Stack Traces | 6.320s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [03-02|10:41:38.141] Blockchain stopped
    precompile_inclusion_test.go:94: goroutine 602517 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.7/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40f1870, 0xc06b440000}, {0x40ae160, 0xc11e8cf3b0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc06b440000, {0x40ae160, 0xc11e8cf3b0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2075 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc06b440000, 0x28, {0xc13ba73df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc06b440000?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc06b440000, 0x3d287d0)
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
INFO [03-02|10:41:43.817] Starting work on payload                 id=0x0347fb8d78119bf9
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (6.32s)

TestAnyTrustRekey

Stack Traces | 9.840s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2075 +0x5d
        github.com/offchainlabs/nitro/system_tests.(*NodeBuilder).BuildL2OnL1(0xc0008f27e0, 0xc00080ec40)
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:935 +0x5ae
        github.com/offchainlabs/nitro/system_tests.TestAnyTrustRekey(0xc00080ec40)
        	/home/runner/work/nitro/nitro/system_tests/anytrust_test.go:162 +0xeca
        testing.tRunner(0xc00080ec40, 0x402b3b0)
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1997 +0x465
        
    common_test.go:935: �[31;1m [failed to deploy ArbDebug] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 2 state: 3 �[0;0m
INFO [03-02|10:42:44.478] releasing chosen one                     myUrl=/home/runner/work/nitro/nitro/target/tmp/deadbeefbee/3203369401/3.ipc attempt=2
WARN [03-02|10:42:44.481] unable to verify sequencer release status due to Redis error: %v "!BADKEY"="redis: client is closed" "!BADKEY"=&lt;nil&gt;                     LOG_ERROR="Normalized odd number of arguments by adding nil"
ERROR[03-02|10:42:44.481] failed to release chosen one status on shutdown err="redis: client is closed"
INFO [03-02|10:42:44.478] Starting work on payload                 id=0x0313d599ebb18648
WARN [03-02|10:42:44.481] Error getting finalizedMessageCount from syncMonitor err="block number not supported: finalized block not found"
INFO [03-02|10:42:44.483] New local node record                    seq=1,772,448,164,479 id=a49fec69af0eb8b2   ip=127.0.0.1 udp=0 tcp=0
INFO [03-02|10:42:44.483] Started P2P networking                   self=enode://516c0378d99c512437c58fb40569e9672edcb0997a625789cb8d15dd816eb318332a0b64ae0209d30f5ee917f369aad785f522316cdd1b741a92ef26d36b50c9@127.0.0.1:0
INFO [03-02|10:42:44.484] New Key                                  name=Faucet              Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
--- FAIL: TestAnyTrustRekey (9.84s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

diegoximenes

Some nitpicks

…c-deletion-of-filtered-tx-hashes

The base branch was changed.

…ion-of-filtered-tx-hashes

diegoximenes · 2026-03-23T17:51:00Z

Closing in favor of another strategy to be later implemented

Delayed Sequencer delegates tx hash deletion to sequencer

0d28fdb

MishkaRogachev force-pushed the seq-automatic-deletion-of-filtered-tx-hashes branch from 703cb39 to 0d28fdb Compare February 6, 2026 17:46

Add small test fix to check filtered tx is deleted after resume

c156e43

MishkaRogachev marked this pull request as ready for review February 6, 2026 19:34

MishkaRogachev requested review from Tristan-Wilson and diegoximenes February 6, 2026 19:35

MishkaRogachev assigned Tristan-Wilson Feb 6, 2026

Tristan-Wilson assigned diegoximenes and unassigned Tristan-Wilson Feb 9, 2026

diegoximenes reviewed Feb 9, 2026

View reviewed changes

Comment thread arbnode/delayed_sequencer.go Outdated

Comment thread cmd/transaction-filterer/api/api.go Outdated

Comment thread cmd/transaction-filterer/api/api.go Outdated

diegoximenes added 4 commits February 9, 2026 14:56

Merge branch 'sequencer_calls_transaction_filterer' into seq-automati…

f608374

…c-deletion-of-filtered-tx-hashes

Warns in case of error when unfiltering transactions

a6a1a56

Updates warning in TransactionFiltererAPI.Unfilter

cf42f64

Fixes namespace in TransactionFiltererRPCClient.Unfilter

0fd3bdc

diegoximenes previously approved these changes Feb 9, 2026

View reviewed changes

diegoximenes assigned tsahee and unassigned diegoximenes Feb 9, 2026

Tristan-Wilson previously approved these changes Feb 10, 2026

View reviewed changes

Base automatically changed from sequencer_calls_transaction_filterer to master February 10, 2026 22:11

diegoximenes mentioned this pull request Feb 11, 2026

Use promises in the ExecutionSequencer interface. Implement it over RPC #4264

Open

Merge branch 'master' into seq-automatic-deletion-of-filtered-tx-hashes

6b306a0

MishkaRogachev requested a review from tsahee February 16, 2026 12:37

MishkaRogachev added 3 commits February 27, 2026 17:20

Merge remote-tracking branch 'origin/master' into seq-automatic-delet…

0992b34

…ion-of-filtered-tx-hashes

Minor post-merge fixes

e3a4ead

Merge branch 'master' into seq-automatic-deletion-of-filtered-tx-hashes

a49413e

MishkaRogachev marked this pull request as draft March 19, 2026 14:52

diegoximenes closed this Mar 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delayed Sequencer delegates tx hash deletion to sequencer#4346

Delayed Sequencer delegates tx hash deletion to sequencer#4346
MishkaRogachev wants to merge 10 commits intomasterfrom
seq-automatic-deletion-of-filtered-tx-hashes

MishkaRogachev commented Feb 6, 2026 •

edited by diegoximenes

Loading

Uh oh!

codecov Bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

diegoximenes left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diegoximenes commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MishkaRogachev commented Feb 6, 2026 • edited by diegoximenes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 10 Tests Failed:

Uh oh!

diegoximenes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diegoximenes commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MishkaRogachev commented Feb 6, 2026 •

edited by diegoximenes

Loading

codecov Bot commented Feb 6, 2026 •

edited

Loading

github-actions Bot commented Feb 6, 2026 •

edited

Loading