ZK Prove Any: tracking PR by pmikolajczyk41 · Pull Request #4361 · OffchainLabs/nitro

pmikolajczyk41 · 2026-02-11T09:14:49Z

NOT INTENDED FOR MERGING (YET)

codecov · 2026-02-11T09:35:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.15%. Comparing base (6dce8d1) to head (e43919f).

❗ There is a different number of reports uploaded between BASE (6dce8d1) and HEAD (e43919f). Click for more details.

HEAD has 8 uploads less than BASE

Flag BASE (6dce8d1) HEAD (e43919f)

15 7

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4361       +/-   ##
===========================================
- Coverage   52.15%   33.15%   -19.00%     
===========================================
  Files         506      506               
  Lines       73739    60415    -13324     
===========================================
- Hits        38458    20033    -18425     
- Misses      30083    36846     +6763     
+ Partials     5198     3536     -1662

github-actions · 2026-02-11T11:00:38Z

❌ 8 Tests Failed:

Tests completed	Failed	Passed	Skipped
5034	8	5026	0

View the top 3 failed tests by shortest run time

TestChallengeToFailedTooFar

Stack Traces | 0.080s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
    challenge_test.go:41: goroutine 3174 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x2dec870, 0xc001206fc0}, {0x2dc8ac0, 0xc00124d650}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/staker/legacy.Require(0xc001206fc0, {0x2dc8ac0, 0xc00124d650}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/staker/legacy/common_test.go:14 +0x5d
        github.com/offchainlabs/nitro/staker/legacy.DeployOneStepProofEntry(0xc001206fc0, 0xc003b9c7e0, {0x2de0490, 0xc003771c08})
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:41 +0x1fd
        github.com/offchainlabs/nitro/staker/legacy.runChallengeTest(0xc001206fc0, 0xc005df1580, {0x2de3118, 0xc005df15a0}, 0x1, 0x0, 0xb)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:135 +0x425
        github.com/offchainlabs/nitro/staker/legacy.TestChallengeToFailedTooFar(0xc001206fc0)
        	/home/runner/work/nitro/nitro/staker/legacy/challenge_test.go:303 +0x118
        testing.tRunner(0xc001206fc0, 0x2be5060)
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.9/x64/src/testing/testing.go:1997 +0x465
        
    challenge_test.go:41: �[31;1m [] replacement transaction underpriced �[0;0m
--- FAIL: TestChallengeToFailedTooFar (0.08s)

TestRedisProduceComplex/one_producer,_some_consumers_killed,_one_retrying_consumer_should_take_over_their_work

Stack Traces | 2.009s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[04-27|15:49:04.471] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=5
�[36mDEBUG�[0m[04-27|15:49:04.477] redis producer: check responses starting
�[36mDEBUG�[0m[04-27|15:49:04.478] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=5
�[36mDEBUG�[0m[04-27|15:49:04.484] redis producer: check responses starting
�[36mDEBUG�[0m[04-27|15:49:04.484] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=5
�[36mDEBUG�[0m[04-27|15:49:04.489] redis producer: check responses starting
�[36mDEBUG�[0m[04-27|15:49:04.490] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=5
�[36mDEBUG�[0m[04-27|15:49:04.496] redis producer: check responses starting
�[36mDEBUG�[0m[04-27|15:49:04.496] request timed out waiting for response   �[36mmsgId�[0m=1777304942492-19 �[36mallowedOldestId�[0m=1777304942496-0
�[36mDEBUG�[0m[04-27|15:49:04.496] request timed out waiting for response   �[36mmsgId�[0m=1777304942492-18 �[36mallowedOldestId�[0m=1777304942496-0
�[36mDEBUG�[0m[04-27|15:49:04.496] request timed out waiting for response   �[36mmsgId�[0m=1777304942492-20 �[36mallowedOldestId�[0m=1777304942496-0
�[36mDEBUG�[0m[04-27|15:49:04.496] request timed out waiting for response   �[36mmsgId�[0m=1777304942492-17 �[36mallowedOldestId�[0m=1777304942496-0
�[36mDEBUG�[0m[04-27|15:49:04.496] request timed out waiting for response   �[36mmsgId�[0m=1777304942492-21 �[36mallowedOldestId�[0m=1777304942496-0
�[36mDEBUG�[0m[04-27|15:49:04.496] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=5 �[36mchecked�[0m=5
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 71, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 72, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 73, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 74, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 75, err: error getting response, request has been waiting for too long
--- FAIL: TestRedisProduceComplex/one_producer,_some_consumers_killed,_one_retrying_consumer_should_take_over_their_work (2.01s)

TestRedisProduceComplex/one_producer,_some_consumers_killed,_one_retrying_consumer_should_take_over_their_work

Stack Traces | 2.080s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[04-27|15:43:56.304] redis producer: check responses starting
�[36mDEBUG�[0m[04-27|15:43:56.305] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=7
�[36mDEBUG�[0m[04-27|15:43:56.310] redis producer: check responses starting
�[36mDEBUG�[0m[04-27|15:43:56.310] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-22 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.310] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-20 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.311] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-26 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.311] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-23 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.311] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-21 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.311] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-25 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.311] request timed out waiting for response   �[36mmsgId�[0m=1777304634308-24 �[36mallowedOldestId�[0m=1777304634310-0
�[36mDEBUG�[0m[04-27|15:43:56.311] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=7 �[36mchecked�[0m=7
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 76, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 77, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 78, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 79, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 80, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 81, err: error getting response, request has been waiting for too long
    pubsub_test.go:385: Unexpected error while awaiting responses, producer: 0, response: 82, err: error getting response, request has been waiting for too long
�[36mDEBUG�[0m[04-27|15:43:56.384] Error destroying a stream group          �[36merror�[0m="dial tcp 127.0.0.1:36169: connect: connection refused"
--- FAIL: TestRedisProduceComplex/one_producer,_some_consumers_killed,_one_retrying_consumer_should_take_over_their_work (2.08s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

CI: cancel old runs & do not require changelog

…main

Merge master

…dencies Cleanup workspace dependencies

Use OCL forks

pmikolajczyk41 · 2026-02-17T13:56:40Z

state for 17 II 2026:

51 files changed
+16'809, -8 lines

…-master

Update master

…ikolajczyk/nit-4503

Use types from validation crate

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

…olchain point secp256k1 to SP1-provided RISC-V toolchain

Merge master

pmikolajczyk41 · 2026-04-21T17:07:25Z

state for 21 IV 2026:

56 files changed
+8'968, -1'031 lines

…. Reduce testcases, do some refactors

…iling Makify SP1. Record a few types of blocks.

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

When you invoke $(MAKE) in a recipe, make automatically: 1. Sets MAKEFLAGS (the make variable). 2. Exports MAKEFLAGS as an environment variable. 3. The sub-make reads MAKEFLAGS from the environment at startup and applies those flags. Passing $(MAKEFLAGS) as positional arguments (make $(MAKEFLAGS)) is redundant, not additive — it's the same info via a second channel. And it's actively harmful because of the argv quoting rules: MAKEFLAGS stores short flags concatenated without a leading dash (e.g. w, sw, j4), so when interpolated onto a command line, w becomes a target, sw becomes a target, etc. The env-based path has no such ambiguity because make parses it itself. Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Sync SP1 README with new Makefile workflow; add run target

…master

Merge master

pmikolajczyk41 self-assigned this Feb 11, 2026

pmikolajczyk41 added 5 commits February 12, 2026 10:23

Cancel workflow run when a new commit arrives

61da4a8

Do not require changelog for PRs not against master

4157eac

Merge pull request #4372 from OffchainLabs/pmikolajczyk/ci-concurrency

9734713

CI: cancel old runs & do not require changelog

Merge remote-tracking branch 'origin/master' into pmikolajczyk/merge-…

72b65c5

…main

Merge pull request #4373 from OffchainLabs/pmikolajczyk/merge-main

4dcd645

Merge master

pmikolajczyk41 marked this pull request as draft February 12, 2026 12:56

pmikolajczyk41 added 11 commits February 13, 2026 16:37

Remove two unused dependencies

fe4aecc

Tidy up workspace deps

f956f0c

Merge pull request #4381 from OffchainLabs/pmikolajczyk/cleanup-depen…

760aebe

…dencies Cleanup workspace dependencies

Add validation to dependencies

797cdc7

Use validation crate for the input reading

14ae070

impl Send for ForceSync (seems to be required by new Rust)

c1dff91

Update path from build.rs

5c2c7a9

Do not decompress twice

d17310d

Remove brotli from dependencies

09830af

Use OCL forks

629b734

Merge pull request #4396 from OffchainLabs/pmikolajczyk/nit-4502-forks

8160a99

Use OCL forks

pmikolajczyk41 added 9 commits February 18, 2026 13:17

Merge remote-tracking branch 'origin/master' into zk-prove-any/update…

6c8e05a

…-master

Merge branch 'zk-prove-any/sp1-runner' into pmikolajczyk/nit-4503

165c20d

Merge pull request #4400 from OffchainLabs/zk-prove-any/update-master

fbfa5a8

Update master

Make user wasm decompressing feature-gated in validation crate

54c0d69

Fix dependencies in sp1 workspace

e1fcdca

Restore Rust brotli decompression

19a4ae0

Merge remote-tracking branch 'origin/zk-prove-any/sp1-runner' into pm…

7118977

…ikolajczyk/nit-4503

Merge pull request #4392 from OffchainLabs/pmikolajczyk/nit-4503

da4e5d2

Use types from validation crate

Merge branch 'master' into zk-prove-any/merge-master

ea93469

pmikolajczyk41 and others added 5 commits April 20, 2026 12:45

fmt

e76b6ed

point secp256k1 to SP1-provided RISC-V toolchain

b15ac09

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Merge pull request #4657 from OffchainLabs/braga/fix-sp1-secp256k1-to…

8d43a7a

…olchain point secp256k1 to SP1-provided RISC-V toolchain

Merge branch 'zk-prove-any/sp1-runner' into zk-prove-any/merge-master

41aa6af

Merge pull request #4652 from OffchainLabs/zk-prove-any/merge-master

a8a984e

Merge master

pmikolajczyk41 and others added 24 commits April 23, 2026 12:26

Add block recording system test (reused Igor's one from benchmarking)…

0c835a8

…. Reduce testcases, do some refactors

Some simplifications

e7734ee

Add Makefile

1327567

Minor fixes to Makefile

040e17c

Remove unused helper

f87c1a7

Run sequentially, update target description

df42887

Move brotli buidling to Makefile

2d1fdc2

make help

a524fd4

Move SP1 installation to Makefile

add62ee

Do not record blocks in build.sh

4d1d7b8

Move building nitro deps to Makefile

39d9b70

Build target instead of build.sh

8a298ab

Add clean target

7aa4e22

Update CI

7ff205f

Install sp1 from makefile

eb64957

Minor fix to make brotli

c40fbb9

cat record.log in case of failure

a1afbf8

Minor fix to the system tests

ced64e8

Merge pull request #4667 from OffchainLabs/pmikolajczyk/nit-4820-prof…

e5a9661

…iling Makify SP1. Record a few types of blocks.

Sync SP1 README with new Makefile workflow; add run target

e6d29eb

Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>

Merge pull request #4672 from OffchainLabs/braga/sync-readme-sp1-build

d1c1a8f

Sync SP1 README with new Makefile workflow; add run target

Merge remote-tracking branch 'origin/master' into zk-prove-any/merge-…

e3a1bbd

…master

Merge pull request #4675 from OffchainLabs/zk-prove-any/merge-master

e43919f

Merge master

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZK Prove Any: tracking PR#4361

ZK Prove Any: tracking PR#4361
pmikolajczyk41 wants to merge 275 commits intomasterfrom
zk-prove-any/sp1-runner

pmikolajczyk41 commented Feb 11, 2026 •

edited by bragaigor

Loading

Uh oh!

codecov Bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

pmikolajczyk41 commented Feb 17, 2026

Uh oh!

pmikolajczyk41 commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pmikolajczyk41 commented Feb 11, 2026 • edited by bragaigor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

NOT INTENDED FOR MERGING (YET)

Uh oh!

codecov Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 8 Tests Failed:

Uh oh!

pmikolajczyk41 commented Feb 17, 2026

Uh oh!

pmikolajczyk41 commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pmikolajczyk41 commented Feb 11, 2026 •

edited by bragaigor

Loading

codecov Bot commented Feb 11, 2026 •

edited

Loading

github-actions Bot commented Feb 11, 2026 •

edited

Loading