[MEL] - Pt.2 Integration of Message Extraction Across Arbnode Behind Feature Flag#4402
Merged
[MEL] - Pt.2 Integration of Message Extraction Across Arbnode Behind Feature Flag#4402
Conversation
Contributor
❌ 10 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
rauljordan
requested review from
diegoximenes,
eljobe and
tsahee
and removed request for
tsahee
rauljordan
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4402 +/- ##
==========================================
+ Coverage 32.71% 33.53% +0.81%
==========================================
Files 494 494
Lines 58386 58612 +226
==========================================
+ Hits 19101 19654 +553
+ Misses 35941 35477 -464
- Partials 3344 3481 +137 |
eljobe
requested changes
Feb 24, 2026
| s.delayedBridge = delayedBridge | ||
| } | ||
|
|
||
| func (s *TransactionStreamer) SetMsgExtractor(msgExtractor *melrunner.MessageExtractor) { |
Member
There was a problem hiding this comment.
Setter injection makes me nervous.
- Why can't we have the TransactionStreamer be correct by construction?
- It "seems" like there is an assumption later in the code that if inboxTracker is not nil, then it will be used. So, if a TransactionStreamer is constructed with an inboxTracker, and then, later
SetMsgExtractoris set, the non-nil inboxTracker would mask the msgExtractor on line 1188. (Maybe this setter should also set the inboxTracker to nil, or error out if it's not nil? - I really hate panics. Isn't there some other way to handle this?
Contributor
Author
There was a problem hiding this comment.
I just pushed some changes to this. I was able to remove the panics and use error checks to ensure correctness, but it is not possible to make both mel and tx streamer correct by construction because it would require a reordering of dependencies in the arbnode/node.go initialization logic, which feels dangerous to me because of how many functions would need to be reordered. I think the new approach is a decent compromise. What do you think?
Contributor
Author
|
Amazing feedback and helpful comments @eljobe ! Thank you. I'll take care of this soon |
eljobe
requested changes
Mar 3, 2026
| s.delayedBridge = delayedBridge | ||
| } | ||
|
|
||
| func (s *TransactionStreamer) SetMsgExtractor(msgExtractor *melrunner.MessageExtractor) { |
eljobe
approved these changes
Mar 8, 2026
joshuacolvin0
added a commit
that referenced
this pull request
Mar 9, 2026
- Return ErrDelayedMessageNotYetFinalized instead of (nil, _, nil) when MEL database doesn't have the parent chain block indexed yet, preventing nil message dereference in delayed sequencer - Remove incorrect waitingForFinalizedBlock assignment that stored a message position where a parent chain block number was expected - Add config validation rejecting BatchPoster + MEL enabled together, since MessageExtractor doesn't implement BatchMetadataFetcher - Remove unused msgExtractor param from getBatchPoster - Fix getDelayedSequencer check ordering so non-sequencer nodes without parent chain reader still return gracefully - Fix grammatical error in delayed sequencer error message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
Fix MEL feature flag bugs from PR #4402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates MessageExtraction across the Nitro node gated behind the MEL feature flag configuration, allowing us to run a MEL-enabled node safely. Some of the changes are refactoring of certain variables to other packages to support MEL, but most changes are straightforward.
Depends on #4398