Skip to content

Shravan taking over for Carlos - update blue square description#3874

Open
sircarmart wants to merge 19 commits intodevelopmentfrom
carlos_update_blue_square_description
Open

Shravan taking over for Carlos - update blue square description#3874
sircarmart wants to merge 19 commits intodevelopmentfrom
carlos_update_blue_square_description

Conversation

@sircarmart
Copy link
Copy Markdown
Contributor

@sircarmart sircarmart commented Aug 9, 2025

Description

This PR modifies blue squares modals to display the first and last name of the author in the format "Assigned by FirstName LastInitial MM/DD/YY".

image

Related PRS (if any):

This frontend PR is related to the #1653 backend PR.

Main changes explained:

  • Pass Auth as a prop in UserProfile.jsx to UserProfileModal.jsx
  • Retrieve logged in user name when adding blue squares in UserProfileModal.jsx
  • Update Add/Update/View blue square modals in UserProfileModal.jsx
  • Update USerProfileModal.test.jsx to test date format of MM/DD/YY

How to test:

  1. run backend branch
  2. check into current branch
  3. do npm install and npm run start:local to run this PR locally
  4. Clear site data/cache
  5. log as admin user
  6. go to any user profile (Nicolle's /userprofile/644db73845fccb5b38b13c14 was used in my testing)
  7. verify adding blue squares matches Jae's requested formatting
  8. verify modifying blue squares matches Jae's requested formatting
  9. verify viewing blue squares (using an account without permission to modify) matches Jae's requested formatting
  10. verify this new feature works in dark mode

Screenshots or videos of changes:

image image

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 9, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 47fcea0
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69d87b156371430008ce77b4
😎 Deploy Preview https://deploy-preview-3874--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

ShravyaKudlu
ShravyaKudlu previously approved these changes Aug 11, 2025
Copy link
Copy Markdown
Contributor

@ShravyaKudlu ShravyaKudlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its working as expected in dark and light mode.
Screenshot from 2025-08-11 17-08-13
Screenshot from 2025-08-11 17-08-51
Screenshot from 2025-08-11 17-09-00
Screenshot from 2025-08-11 17-09-39

ujjwalbPipKcK
ujjwalbPipKcK previously approved these changes Aug 12, 2025
Copy link
Copy Markdown
Contributor

@ujjwalbPipKcK ujjwalbPipKcK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Blue Square is working as intended in both Light Mode and Dark Mode.
image

And cant Update BlueSquares with a volunteer account
image

Copy link
Copy Markdown

@JERRRRY JERRRRY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI works well under Dark and Light mode.
Screenshot 2025-08-14 at 6 19 35 PM
Screenshot 2025-08-14 at 6 19 17 PM

@sircarmart sircarmart added the do not review Do not review or look at code without full context label Sep 20, 2025
@sircarmart sircarmart force-pushed the carlos_update_blue_square_description branch from 82da5f4 to 25e7b44 Compare September 20, 2025 18:28
@sircarmart sircarmart removed the do not review Do not review or look at code without full context label Sep 20, 2025
@sircarmart
Copy link
Copy Markdown
Contributor Author

Ran into some issues while resolving a conflict, good to review/merge now.

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Carlos,

I have reviewed your PR locally and the it does work as per requirement in light mode but in dark mode - the assigning page is in light mode in the text boxes and in the viewing of the blue sqaure, the person's name is not clearly visible.
Issue:
Image
Image
Working Screenshots
Image
Image
Image
Image
Image
Image
Image

@one-community one-community changed the title Carlos update blue square description Shravan taking over for Carlos - update blue square description Feb 28, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shravan,

Thanks for updating the PR and making the changes in the dark mode. I was able to view the details as per requirement in both the modes. However this is one issue which could be out of scope is the calendar is in light mode while the application is in dark mode and the calendar icon too is not that UI friendly in dark mode. Please confirm with Jae and do let me know if it is not in your scope and i will update the review.

Issue
Image
Image

Working functionality
Image
Image
Image
Image
Image
Image

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shravan,

Thanks for the updates. I was able to test everything in both light and dark modes, and the changes look good.

One small thing I noticed is that the calendar still shows in light mode when the app is in dark mode, and the calendar icon does not look very consistent with the dark theme. I am not sure if this is part of the current scope. Please let me know.

Image Image Image Image Image Image Image

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 16, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sharvan,

Thank you for making the update, however i suppose they broke the formating as you can see in the below screenshots. The text in the Summary is in the center of the text box with no word-wrap.

Image Image Image Image Image Image Image Image Image Image Image

@Shravan-neelamsetty Shravan-neelamsetty force-pushed the carlos_update_blue_square_description branch from a5bfe54 to 9f5a1d5 Compare April 8, 2026 19:38
@sonarqubecloud
Copy link
Copy Markdown

@Shravan-neelamsetty
Copy link
Copy Markdown

Hi Anusha,
I made some changes to the code and fixed it can you go ahead and test it again and update me if there is anything i have to work and and solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants