Shravan taking over for Carlos - update blue square description#3874
Shravan taking over for Carlos - update blue square description#3874sircarmart wants to merge 19 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
82da5f4
82da5f4 to
25e7b44
Compare
|
Ran into some issues while resolving a conflict, good to review/merge now. |
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Shravan,
Thanks for updating the PR and making the changes in the dark mode. I was able to view the details as per requirement in both the modes. However this is one issue which could be out of scope is the calendar is in light mode while the application is in dark mode and the calendar icon too is not that UI friendly in dark mode. Please confirm with Jae and do let me know if it is not in your scope and i will update the review.
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Shravan,
Thanks for the updates. I was able to test everything in both light and dark modes, and the changes look good.
One small thing I noticed is that the calendar still shows in light mode when the app is in dark mode, and the calendar icon does not look very consistent with the dark theme. I am not sure if this is part of the current scope. Please let me know.
a5bfe54 to
9f5a1d5
Compare
|
|
Hi Anusha, |







































Description
This PR modifies blue squares modals to display the first and last name of the author in the format "Assigned by FirstName LastInitial MM/DD/YY".
Related PRS (if any):
This frontend PR is related to the #1653 backend PR.
Main changes explained:
UserProfile.jsxtoUserProfileModal.jsxUserProfileModal.jsxUserProfileModal.jsxUSerProfileModal.test.jsxto test date format of MM/DD/YYHow to test:
npm installandnpm run start:localto run this PR locallyScreenshots or videos of changes: