Skip to content

Amalesh - PR4548 Bugfixes#4694

Open
Amalesh-A wants to merge 15 commits intodevelopmentfrom
Amalesh-totalorgsummary-bugfixes
Open

Amalesh - PR4548 Bugfixes#4694
Amalesh-A wants to merge 15 commits intodevelopmentfrom
Amalesh-totalorgsummary-bugfixes

Conversation

@Amalesh-A
Copy link
Copy Markdown
Contributor

@Amalesh-A Amalesh-A commented Jan 10, 2026

Description

image

Related PRS (if any):

This frontend PR is related to the development branch of the backend.
Related PR: #4548

Main changes explained:

  • Updated 'HoursCompletedBarChart.jsx'
  • Updated 'VolunteerTrendsLineChart.jsx'
  • Updated 'AnniversaryCelebrated.jsx'
  • Updated 'TeamStats.jsx'

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as an user
  5. go to dashboard→ Total Org Summary
  6. Check if the above bugs are resolved

Screenshots or videos of changes:

Before:
https://github.com/user-attachments/assets/ea2bb9a9-71ca-490b-99c5-86bed108ef86

After:
https://github.com/user-attachments/assets/2742e69b-5e2e-4074-a86d-534dcff22b20

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 10, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 191ea4a
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69d93f1564ab4d0008706e95
😎 Deploy Preview https://deploy-preview-4694--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Amalesh-A Amalesh-A changed the title Bugfixes Amalesh - PR4548 Bugfixes Jan 10, 2026
@Amalesh-A Amalesh-A added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jan 13, 2026
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amalesh,

Well done with this implementation. A couple issues are the bar graph overlays are over-sized. Also the blue square has black text (see image below.)

PR 4694 Screenshot PR 4694 Screenshot 2

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amalesh,

I have found one more discrepancy, as you can see the dropdown symbol is not visible in dark mode.
Screenshot 2026-01-14 at 6 33 24 PM
Screenshot 2026-01-14 at 6 33 29 PM
Rest issues are fixed
Screenshot 2026-01-14 at 6 28 04 PM
Screenshot 2026-01-14 at 6 32 39 PM
Screenshot 2026-01-14 at 6 32 41 PM
Screenshot 2026-01-14 at 6 32 54 PM

@Amalesh-A
Copy link
Copy Markdown
Contributor Author

Hi Anusha, thank you for your comments. I really appreciate you taking time to review my pull request. I am unsure why you are not able to view the dropdown button, but I am able to see it on my device.

image image

@sonarqubecloud
Copy link
Copy Markdown

@Amalesh-A Amalesh-A dismissed stale reviews from Anusha-Gali and rohanrastogi311 January 31, 2026 09:23

The issues could not be replicated.

Copy link
Copy Markdown
Contributor

@sayali-2308 sayali-2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image - Branch: `Amalesh-totalorgsummary-bugfixes` - Backend: `development` branch - Tested on: Windows, Chrome, Dark mode - Date: January 31, 2026

Bugs Verified - Fixed:

  1. **Volunteer Trends By Time dropdowns - FIXED:

    • "This year" dropdown now has white text, clearly visible
    • "by week" dropdown now has white text, clearly visible
    • Previously reported as not visible - now working correctly
  2. Anniversary Celebrated text - FIXED:

    • User names visible with proper contrast
    • Join dates displayed correctly
    • Red M icons and profile images visible
    • Text readable in dark mode
  3. Hours Completed section - FIXED:

    • All three charts display correctly (Volunteer Hours Distribution, Task Completed, Hours Completed)
    • Dark mode adaptation working properly
    • "Projects" label with stats (81.92, 5.00%, 0%) visible in white box
    • Graph displays with blue line correctly
    • No block issues observed
  4. Other sections working correctly:

    • Work Distribution and Role Distribution charts visible
    • Blue Square Stats displaying properly
    • Global Distribution map and Volunteer Status charts functional

Issue Still Remaining:
Team Stats dropdown text not visible in dark mode:
Location:"Teams and Blue Squares" section → "Team Stats" → "210 teams with [dropdown] + active members"
Issue: The dropdown field displaying the number (appears to show "2") has black/dark text on a dark background, making it completely unreadable.
Expected: Dropdown text should be white (like other dropdowns on the page: "This year", "by week") to be visible against the dark background.

@Amalesh-A
Copy link
Copy Markdown
Contributor Author

Image - Branch: Amalesh-totalorgsummary-bugfixes - Backend: development branch - Tested on: Windows, Chrome, Dark mode - Date: January 31, 2026

Bugs Verified - Fixed:

1. **Volunteer Trends By Time dropdowns - FIXED:
   
   * "This year" dropdown now has white text, clearly visible
   * "by week" dropdown now has white text, clearly visible
   * Previously reported as not visible - now working correctly

2. Anniversary Celebrated text - FIXED:
   
   * User names visible with proper contrast
   * Join dates displayed correctly
   * Red M icons and profile images visible
   * Text readable in dark mode

3. Hours Completed section - FIXED:
   
   * All three charts display correctly (Volunteer Hours Distribution, Task Completed, Hours Completed)
   * Dark mode adaptation working properly
   * "Projects" label with stats (81.92, 5.00%, 0%) visible in white box
   * Graph displays with blue line correctly
   * No block issues observed

4. Other sections working correctly:
   
   * Work Distribution and Role Distribution charts visible
   * Blue Square Stats displaying properly
   * Global Distribution map and Volunteer Status charts functional

Issue Still Remaining: Team Stats dropdown text not visible in dark mode: Location:"Teams and Blue Squares" section → "Team Stats" → "210 teams with [dropdown] + active members" Issue: The dropdown field displaying the number (appears to show "2") has black/dark text on a dark background, making it completely unreadable. Expected: Dropdown text should be white (like other dropdowns on the page: "This year", "by week") to be visible against the dark background.

Hi, Thanks for reviewing but I am not able to see the issue that you mentioned.

image

@sayali-2308
Copy link
Copy Markdown
Contributor

sayali-2308 commented Feb 1, 2026 via email

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amalesh,

I reviewed the changes locally and most of the issues look improved. The dropdown texts in Volunteer Trends by Time and the text in Anniversary Celebrated are now clearly visible.

However, I noticed that in several places across the page, when hovering over the graphs the tooltip values are not clearly visible. Also, in Team Stats, the dropdown is visible but the selected value inside it is not clearly readable.

Image Image Image Image

naznin07
naznin07 previously approved these changes Mar 18, 2026
Copy link
Copy Markdown

@naznin07 naznin07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce inline styling commented code.

PR # 4694

@Amalesh-A Amalesh-A force-pushed the Amalesh-totalorgsummary-bugfixes branch 2 times, most recently from 7717c76 to 2958e12 Compare March 27, 2026 10:25
@Amalesh-A
Copy link
Copy Markdown
Contributor Author

Hello @Anusha-Gali and @sayali-2308 , I’ve implemented the changes to the dropdown menu under “Team Stats.” Could you please review them and let me know your feedback?

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amalesh,

I have reviewed your PR locally. Most of the issues mentioned in the ticket are fixed, however I noticed a couple of remaining issues:

  1. The Projects block under the Hours Completed graph is not adapted to dark mode.
  2. The hover tooltip in Team Stats is not styled for dark mode.
Image Image

Anusha-Gali
Anusha-Gali previously approved these changes Apr 9, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Amalesh,

Thank you for fixing the issue. Every requirement appears to be met.

Image Image

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants