uha fix construction dashboard#5035
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
one-community
added
the
High Priority - Please Review First
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Uha,
I tested this PR locally and the dropdown visibility and calendar in dark mode are both fixed. However, I noticed the bubble chart image appears to be cropped. Does this fall under the scope of this PR?
Vishnu10-hub
left a comment
Vishnu10-hub
left a comment
There was a problem hiding this comment.
Hi,
Tested locally on fix-construction-dashboard. The functionality is working correctly in both light and dark modes, and the dropdown behavior is as expected. The chart appears slightly cropped, but it matches the demo screenshot provided, so it seems consistent with the given requirements.
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Uha,
Part of the graph is clipping at the bottom.
saisandeepkoritala
left a comment
saisandeepkoritala
left a comment
There was a problem hiding this comment.
Hi Uha,
I ran your PR locally and found out that one of the graph is not rendering as expected. Please find the below image for reference.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Uha,
As per the scope of the PR the issues mentioned appear to be fixed however as you might have also noticed the map is clipped in all directions
uhakruthi1
dismissed stale reviews from Anusha-Gali and Vishnu10-hub
via
93d0e07
uhakruthi1
force-pushed
the
fix-construction-dashboard
branch
from
ca93a47 to
93d0e07
Compare
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Uha,
Thank you for fixing the issues. The chart is fixed and the requirements are met.
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Uha,
Well done with this.
uhakruthi1
dismissed stale reviews from rohanrastogi311 and Anusha-Gali
via
d89b318
|
|
Thank you all, merging! |
7 participants
Description
Related PRS (if any):
This frontend PR is related to the development backend PR.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Before :
after :
Note:
Include the information the reviewers need to know.