Yu Yan - Fix: Dark Mode compatibility for InjuryChart component (PR #4316 foll…#5064
Open
yany960 wants to merge 5 commits intodevelopmentfrom
Open
Yu Yan - Fix: Dark Mode compatibility for InjuryChart component (PR #4316 foll…#5064yany960 wants to merge 5 commits intodevelopmentfrom
yany960 wants to merge 5 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ow-up) Replace Bootstrap 'bg-white' class with CSS module 'styles.lightBackground' to ensure proper Dark Mode support across filter form and chart containers.
yany960
force-pushed
the
fix-injurychart-darkmode
branch
3 times, most recently
from
e0bbe69 to
860e795
Compare
yany960
force-pushed
the
fix-injurychart-darkmode
branch
from
860e795 to
f0ce8c2
Compare
|
one-community
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Dark Mode compatibility for InjuryChart component (PR #4316 follow-up).
The original PR #4316 used Bootstrap's
bg-whiteclass which forced white background in Dark Mode, causing visual inconsistency. This PR replaces Bootstrap utility classes with CSS module-based Dark Mode support.Related PRS (if any):
Reference Previous PRs - FE-#4316 + BE-#1468 --> replaced by #2347
Main changes explained:
bg-whitewith CSS modulestyles.lightBackground.lightBackgroundclass for Light Mode stylingFiles modified:
src/components/BMDashboard/InjuryChart/InjuryChartForm.jsximport styles from './InjuryChartForm.module.css'bg-whitewithstyles.lightBackgroundbg-dark text-light/bg-secondary text-lightwithstyles.wrapperDarksrc/components/BMDashboard/InjuryChart/InjuryChartForm.module.css.lightBackgroundclass for Light Mode backgroundsrc/components/BMDashboard/InjuryChart/InjuryChart.module.cssHow to test:
git checkout fix-injurychart-darkmodenpm installandnpm startto run this PR locallyScreenshots of changes:
Before (Dark Mode - Issue):
After (Dark Mode - Fixed):
Note:
This is a follow-up fix to PR #4316 to address the Dark Mode compatibility issue mentioned in the review comments.