Skip to content

veda-LBDashboard-fix#5126

Open
Charitha2009 wants to merge 1 commit intodevelopmentfrom
veda-lbdashboard-fix
Open

veda-LBDashboard-fix#5126
Charitha2009 wants to merge 1 commit intodevelopmentfrom
veda-lbdashboard-fix

Conversation

@Charitha2009
Copy link
Copy Markdown
Contributor

Description

Screenshot 2026-04-09 at 6 51 05 PM

Related PRS (if any):

This frontend PR is related to the development backend PR.

Main changes explained:

  • LBDashboard.jsx — dateRange is memoized so opening metric dropdowns does not recreate it and retrigger charts.
  • DemandOverTime.jsx — Chart loading keys off the actual date range (timestamps), not the array reference, so charts do not refresh unnecessarily.
  • chartsUtils .js— Extra top padding + Y-axis grace so high value labels are not clipped.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/lbdashboard
  6. Open/close the caret next to Demand / Vacancy / Revenue without changing metric → line charts should not jump.
    Check tall points → numbers above dots should be fully visible.
  7. Repeat in dark mode.

Screenshots or videos of changes:

Screenshot 2026-04-09 at 6 53 31 PM Screenshot 2026-04-09 at 6 53 57 PM

…abels

- Memoize dateRange in LBDashboard so metric dropdown toggles do not
  regenerate DemandOverTime dummy series.
- Key DemandOverTime effect on date bounds so new array refs with the
  same range do not refetch.
- Add y-axis grace and extra top layout padding in chart options so
  point labels near the max are not clipped.

Made-with: Cursor
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 0a61472
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69d82e2ce7608e0008503418
😎 Deploy Preview https://deploy-preview-5126--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Charitha2009 Charitha2009 changed the title fix(LBDashboard): stable date range for charts; prevent clipped datal… veda-LBDashboard-fix Apr 9, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant