Yu Yan taking over: complete server date protection for timelog and weekly summary#5129
Open
yany960 wants to merge 2 commits intodevelopmentfrom
Open
Yu Yan taking over: complete server date protection for timelog and weekly summary#5129yany960 wants to merge 2 commits intodevelopmentfrom
yany960 wants to merge 2 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR takes over and replaces the abandoned work from PR #4312 to fully protect timelog and weekly summary flows from local/system date manipulation.
Related PRs
Main changes explained
ServerTimeContextto centralize authoritative server-date access and periodic re-sync logic.ServerTimeProviderso time-sensitive flows can use the same server-based date source.GET_SERVER_DATEfrontend endpoint wiring for the related backend API.TimeEntryFormto initialize and refreshdateOfWorkfrom server time instead of the local machine clock.TimeEntrysame-day checks to use server time rather than local time.Timelogweek boundary calculations and date labels to use server time.WeeklySummarydue-date initialization and week-belonging checks so the dashboard due date no longer follows modified local/system time.ServerTimeProvider.Why this replaces PR #4312
Review feedback on #4312 showed that changing the computer date/time could still:
This replacement PR keeps the original server-date approach but closes the remaining gaps where local
moment()usage was still leaking into weekly summary and timelog behavior.How to test
codex/yuyan-pr4312-server-date.