fix: persist deselected account state across chain switches (OK-51089)

[PatrickChoo]

Summary

• Fix manage accounts page losing "delete" account selections when switching chains
• Previously, deselectedExistingIndexes was reset on network/deriveType change while normalSelectedIndexes (add selections) was preserved
• Now both add and delete selections persist across chain switches, aligned behavior

Test plan

• Open manage accounts page
• Check some accounts to add and uncheck some existing accounts (mark for deletion)
• Switch to a different chain
• Verify both add selections and delete selections are preserved
• Confirm the final operation works correctly with persisted selections

Jira: OK-51089

---

[revan-zhang]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 10 additional findings.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 9 additional findings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[socket-security]

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 42 additional findings in Devin Review.

[devin-ai-integration]

🔴 Stale closure in headerRight causes saveDeselectionToCache to save outdated deselection state on derive type switch

saveDeselectionToCache (line 340) closes over deselectedExistingIndexes state and is listed in its useCallback deps (line 350). However, headerRight's useCallback (line 519) does NOT include saveDeselectionToCache in its dependency array (lines 610-619). When a user deselects accounts and then switches derive type, the onChange handler at line 562 calls a stale saveDeselectionToCache that captured the old (empty) deselectedExistingIndexes — the user's deselections are silently lost and cannot be restored when switching back. This directly breaks the PR's intended feature of persisting deselection state across derive type switches.

Triggering flow

1. User is on networkA with deriveTypeA, headerRight is created.
2. User deselects some existing accounts → deselectedExistingIndexes updates → saveDeselectionToCache is recreated.
3. headerRight is NOT recreated because saveDeselectionToCache is not in its dependency array.
4. User switches to deriveTypeB → onChange fires with the stale saveDeselectionToCache from step 1.
5. Stale saveDeselectionToCache saves {} (empty) to cache key networkA__deriveTypeA.
6. User switches back to deriveTypeA → empty state is restored, deselections are gone.

(Refers to lines 610-619)

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[PatrickChoo]

Closing: PR had too many unrelated changes mixed in. Reopening as a clean PR with only the OK-51089 fix.