Skip to content

refactor: align custom font class with resource pack definition#62

Merged
theEvilReaper merged 5 commits intodevelopfrom
rework/font
Mar 29, 2026
Merged

refactor: align custom font class with resource pack definition#62
theEvilReaper merged 5 commits intodevelopfrom
rework/font

Conversation

@theEvilReaper
Copy link
Copy Markdown
Contributor

Proposed changes

The original idea was to have a font record which represents a font entry from a resource pack. This also comes with a key which represents the entry itself. Unfortunately the idea with the key makes it less a data representation. So this pull request overhauls the structure to have a easy data representation of a font entry.

This comes with the advantage that each developer can do their own mapping to have Key -> Font.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Mar 29, 2026
@theEvilReaper theEvilReaper added the enhancement New feature or request label Mar 29, 2026
@theEvilReaper theEvilReaper changed the title refactor: update custom font class to represent the resource pack definition refactor: update custom font class to represent resource pack definition Mar 29, 2026
@theEvilReaper theEvilReaper changed the title refactor: update custom font class to represent resource pack definition refactor: align custom font class with resource pack definition Mar 29, 2026
@theEvilReaper theEvilReaper merged commit 86e4aaa into develop Mar 29, 2026
7 checks passed
@theEvilReaper theEvilReaper deleted the rework/font branch March 29, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant