Skip to content

fix: Set keyboard focus on dialogs for accessibility (MAS 2.4.7) #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claude wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

fix: Set keyboard focus on dialogs for accessibility (MAS 2.4.7) #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/scripts/clipperUI/panels/regionSelectingPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import {ClipperStateProp} from "../clipperState";
import {ComponentBase} from "../componentBase";

class RegionSelectingPanelClass extends ComponentBase<{}, ClipperStateProp> {
initiallySetFocus(element: HTMLElement) {
element.focus();
}

handleCancelButton() {
this.props.clipperState.setState({
focusOnRender: Constants.Ids.regionButton
Expand All @@ -28,6 +32,7 @@ class RegionSelectingPanelClass extends ComponentBase<{}, ClipperStateProp> {
</div>
<div className="wideButtonContainer">
<a id={ Constants.Ids.regionClipCancelButton } role="button"
{...this.onElementFirstDraw(this.initiallySetFocus)}
{...this.enableInvoke({callback: this.handleCancelButton, tabIndex: 0})} >
<span className="wideButtonFont wideActionButton buttonTextInHighContrast" style={Localization.getFontFamilyAsStyle(Localization.FontFamily.Semibold)}>
{Localization.getLocalizedString("WebClipper.Action.BackToHome")}
Expand Down
5 changes: 5 additions & 0 deletions src/scripts/clipperUI/panels/successPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ import {Clipper} from "../frontEndGlobals";
import {SpriteAnimation} from "../components/spriteAnimation";

class SuccessPanelClass extends ComponentBase<{ }, ClipperStateProp> {
initiallySetFocus(element: HTMLElement) {
element.focus();
}

public onLaunchOneNoteButton() {
Clipper.logger.logUserFunnel(Log.Funnel.Label.ViewInWac);
let data = this.props.clipperState.oneNoteApiResult.data as OneNoteApi.Page;
Expand All @@ -38,6 +42,7 @@ class SuccessPanelClass extends ComponentBase<{ }, ClipperStateProp> {
</div>
<div className="wideButtonContainer">
<a id={Constants.Ids.launchOneNoteButton} className="wideButtonFont wideActionButton buttonTextInHighContrast" role="button"
{...this.onElementFirstDraw(this.initiallySetFocus)}
{...this.enableInvoke({callback: this.onLaunchOneNoteButton, tabIndex: 70})}
style={Localization.getFontFamilyAsStyle(Localization.FontFamily.Regular)}>
{Localization.getLocalizedString("WebClipper.Action.ViewInOneNote")}
Expand Down
Loading