Skip to content

feat: add Huawei and email_reply_to_address parameters to Notification#61

Merged
sherwinski merged 1 commit intomainfrom
user-api-updates
Mar 24, 2026
Merged

feat: add Huawei and email_reply_to_address parameters to Notification#61
sherwinski merged 1 commit intomainfrom
user-api-updates

Conversation

@onesignal-deploy
Copy link
Collaborator

@onesignal-deploy onesignal-deploy commented Jan 29, 2026 •
edited by sherwinski
Loading

Features

Adds the following Notification parameters:

  • huawei_badge_class
  • huawei_badge_add_num
  • huawei_badge_set_num
  • huawei_category
  • huawei_bi_tag
  • email_reply_to_address

@onesignal-deploy onesignal-deploy force-pushed the user-api-updates branch 2 times, most recently from 5c747e6 to ba3553b Compare February 2, 2026 19:13
@sherwinski sherwinski changed the title Add v5.3.0-beta1 package updates Add v5.3.0 package updates Mar 24, 2026
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2026
View reviewed changes
.github/workflows/release.yml
Comment on lines +44 to +73
name: Publish to PyPI
needs: release
if: needs.release.outputs.new_release_published == 'true'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- name: Set up Python 3.10
uses: actions/setup-python@v6
with:
python-version: "3.10"
- name: Install pypa/build
run: >-
python -m
pip install
build
--user
- name: Build a binary wheel and a source tarball
run: >-
python -m
build
--sdist
--wheel
--outdir dist/
.
- name: Publish a Python distribution to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}
verbose: true

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 2 days ago

To fix the problem, the publish job needs an explicit permissions block limiting the default GITHUB_TOKEN privileges to only what is required. This job checks out the repository and runs build and publish steps, but does not need to write to the repository or manipulate issues/PRs. The minimal recommended permission is contents: read, which allows checkout and reading repository files but not pushing changes, creating releases, or modifying other resources.

Concretely, in .github/workflows/release.yml, under the publish job (line 43 onwards), add a permissions: section at the same indentation level as runs-on: and needs:. Set it to:

permissions:
  contents: read

This keeps existing functionality intact: actions/checkout still works, the job still builds artifacts and publishes to PyPI using the PyPI token, and no other behavior is changed. No imports or additional methods are needed, as this is purely a YAML configuration change within the workflow.

Suggested changeset 1
.github/workflows/release.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -45,6 +45,8 @@
     needs: release
     if: needs.release.outputs.new_release_published == 'true'
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
       - uses: actions/checkout@v5
       - name: Set up Python 3.10
EOF
@@ -45,6 +45,8 @@
needs: release
if: needs.release.outputs.new_release_published == 'true'
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- uses: actions/checkout@v5
- name: Set up Python 3.10
Copilot is powered by AI and may make mistakes. Always verify output.
@sherwinski sherwinski changed the title Add v5.3.0 package updates feat: add Huawei and email_reply_to_address parameters to Notification Mar 24, 2026
@sherwinski sherwinski changed the title feat: add Huawei and email_reply_to_address parameters to Notification Add v5.3.0 package updates Mar 24, 2026
@sherwinski sherwinski changed the title Add v5.3.0 package updates feat: add Huawei and email_reply_to_address parameters to Notification Mar 24, 2026
@sherwinski sherwinski merged commit 58ed6cc into main Mar 24, 2026
3 checks passed
@sherwinski sherwinski deleted the user-api-updates branch March 24, 2026 19:04
github-actions bot pushed a commit that referenced this pull request Mar 24, 2026
@semantic-release-bot
chore(release): 5.3.0
4e5b736 
## [5.3.0](v5.2.0...v5.3.0) (2026-03-24)

### Features

* add Huawei and email_reply_to_address parameters to Notification ([#61](#61)) ([58ed6cc](58ed6cc))
 [skip ci]
@github-actions
Copy link

github-actions bot commented Mar 24, 2026

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sherwinski sherwinski sherwinski approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onesignal-deploy @sherwinski