[rust] Fix array enums for generated object types#23279
Open
rgroothuijsen wants to merge 2 commits intoOpenAPITools:masterfrom
Open
[rust] Fix array enums for generated object types#23279rgroothuijsen wants to merge 2 commits intoOpenAPITools:masterfrom
rgroothuijsen wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/test/resources/3_1/issue_23278.yaml">
<violation number="1" location="modules/openapi-generator/src/test/resources/3_1/issue_23278.yaml:15">
P2: The new OpenAPI 3.1 regression fixture uses invalid schema typing (`type: TestObject/TestArray`) instead of `$ref` for component schemas, so the test may not represent valid input or the intended code path.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
modules/openapi-generator/src/test/resources/3_1/issue_23278.yaml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue as described in #23278 by deriving the model name from the
baseTypeinstead of thedataType, which produces names likeTestObjectrather thanmodels::TestObjectand thus avoids a syntax error.Fixes #23278
@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes generation of oneOf array enum names for object types in the Rust client by using the item's
baseType, preventing invalid identifiers and syntax errors. Fixes #23278.baseTypeinstead ofdataTypeto avoid prefixes likemodels::.$refnotation) that assert generated enums includeVec<models::TestObject>andVec<models::TestArray>.Written for commit 6020381. Summary will update on new commits.