Skip to content

[rust] Fix array enums for generated object types#23279

Open
rgroothuijsen wants to merge 2 commits intoOpenAPITools:masterfrom
rgroothuijsen:issue-23278
Open

[rust] Fix array enums for generated object types#23279
rgroothuijsen wants to merge 2 commits intoOpenAPITools:masterfrom
rgroothuijsen:issue-23278

Conversation

@rgroothuijsen
Copy link
Contributor

@rgroothuijsen rgroothuijsen commented Mar 17, 2026

This fixes the issue as described in #23278 by deriving the model name from the baseType instead of the dataType, which produces names like TestObject rather than models::TestObject and thus avoids a syntax error.

Fixes #23278

@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes generation of oneOf array enum names for object types in the Rust client by using the item's baseType, preventing invalid identifiers and syntax errors. Fixes #23278.

  • Bug Fixes
    • Build enum variant names with baseType instead of dataType to avoid prefixes like models::.
    • Add an OpenAPI 3.1 spec and test (with corrected $ref notation) that assert generated enums include Vec<models::TestObject> and Vec<models::TestArray>.

Written for commit 6020381. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/test/resources/3_1/issue_23278.yaml">

<violation number="1" location="modules/openapi-generator/src/test/resources/3_1/issue_23278.yaml:15">
P2: The new OpenAPI 3.1 regression fixture uses invalid schema typing (`type: TestObject/TestArray`) instead of `$ref` for component schemas, so the test may not represent valid input or the intended code path.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][rust] oneOf array enums produce invalid syntax for generated object types

2 participants