Add bind_address property for http4s server configuration#2714
Merged
simonredfern merged 2 commits intoOpenBankProject:developfrom Feb 27, 2026
Merged
Conversation
aa4236b to
f9edb6f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This PR adds a new
bind_addressproperty for http4s server configuration, providing more flexibility in network binding while maintaining backward compatibility.Changes
Added
Http4sConfigUtil.parseHostname()utility inHttp4sSupport.scalaUpdated
Http4sServer.scalato use the newbind_addresspropertybind_addressproperty if sethostnameproperty ifbind_addressis not sethostnameproperty remains unchanged (critical forlocal_provider_namefallback)Added comprehensive test suite
Http4sConfigUtilTest.scalaMotivation
The
hostnameproperty is used as a fallback forlocal_provider_name, which affects user authentication. Changing it could break existing user logins. The newbind_addressproperty allows operators to specify the network binding address independently without affecting authentication logic.Backward Compatibility
✅ Fully backward compatible - if
bind_addressis not set, the system behaves exactly as before by parsing thehostnameproperty.Testing