Conversation
level 1 headers are not included as per the markdown generation config, so page h1 titles no longer need to be explicitally ignored. + the omit tag no longer works with generation
OBPeteS
left a comment
OBPeteS
left a comment
There was a problem hiding this comment.
1 change requested and a couple of comments asking for further details on changes
docs/.vuepress/config.js
Outdated
|
|
||
| module.exports = { | ||
| base: '/read-write-api-site3/', | ||
| base: '/test-toc-links/', |
There was a problem hiding this comment.
This needs changing back to the prod url
| lineNumbers: false, | ||
| // options for markdown-it-anchor | ||
| anchor: { | ||
| permalinkBefore: true, |
There was a problem hiding this comment.
What's the impact (if any of this being removed?)
There was a problem hiding this comment.
The docs said they apply by default, so there should be no change. But I can change them back for consistency?
| .badge | ||
| vertical-align middle | ||
|
|
||
| .table-of-contents > ul > li > a |
There was a problem hiding this comment.
Can you cover off this addition please so we have a record of why it was added on the PR
There was a problem hiding this comment.
I've added some comments. let me know if that suffices?
| smoothScroll: true, | ||
| lastUpdated: false, | ||
| }, | ||
| markdown: markdownConfig, |
There was a problem hiding this comment.
Can you cover this addition please
There was a problem hiding this comment.
I have added some comments addressing this addition. However, for context, the markdown config file already existed, but was never imported directly into the VuePress config - now it is :)
3 participants
related to CDRW-5016
Testing link: https://openbankinguk.github.io/test-toc-links/v4.0.1/profiles/read-write-data-api-profile.html