[PATCH v2] api: crypto: add ZUC 256 algorithm#2335
Open
nkaithakadan wants to merge 1 commit intoOpenDataPlane:masterfrom
Open
[PATCH v2] api: crypto: add ZUC 256 algorithm#2335nkaithakadan wants to merge 1 commit intoOpenDataPlane:masterfrom
nkaithakadan wants to merge 1 commit intoOpenDataPlane:masterfrom
Conversation
odpbuild
changed the title
Add ZUC256 cipher and integrity algorithm. Signed-off-by: Nithinsen Kaithakadan <nkaithakadan@marvell.com>
nkaithakadan
force-pushed
the
zuc_v2_spec
branch
from
1d8b848 to
99c4cfb
Compare
odpbuild
changed the title
Contributor
Author
|
@JannePeltonen Could you review these changes |
| * https://eprint.iacr.org/2021/1439 | ||
| */ | ||
| ODP_CIPHER_ALG_ZUC_EEA3, | ||
| ODP_CIPHER_ALG_ZUC_NEA6, |
Collaborator
There was a problem hiding this comment.
This change is not really adding a new algorithm in the API as the commit message says but just moves the currently defined 256-bit ZUC variant with 16-byte-IV from ODP_CIPHER_ALG_ZUC_EEA3 to ODP_CIPHER_ALG_ZUC_NEA6.
But, AFAIK, the algorithm defined in the referenced document is not exactly the same as NEA6 (unless things have recently changed), so adding a new algorithm name is fine, but it should not reference that document.
If we are adding ..._NEA6 and ..._NIA6 then maybe ..._NCA6 should be added too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ZUC256 cipher and integrity algorithm.