[PATCH v2] test/dyn_workers: fix teardown order#2336
Open
PavanNikhilesh wants to merge 1 commit intoOpenDataPlane:masterfrom
Open
[PATCH v2] test/dyn_workers: fix teardown order#2336PavanNikhilesh wants to merge 1 commit intoOpenDataPlane:masterfrom
PavanNikhilesh wants to merge 1 commit intoOpenDataPlane:masterfrom
Conversation
TuomasTaipale
approved these changes
Apr 14, 2026
Collaborator
TuomasTaipale
left a comment
There was a problem hiding this comment.
Thanks for the patch. Commit subject line could be changed to
test: dyn_workers: fix teardown order
to match existing style, otherwise OK.
Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reverse the process teardown loop so secondaries call odp_term_local before the primary calls odp_term_global, preventing resource teardown ordering errors. Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
f32a084 to
aae3793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverse the process teardown loop so secondaries call odp_term_local before the primary calls odp_term_global, preventing resource teardown ordering errors.