[feature/patina-boot] patina_boot: Implement full console discovery by kat-perez · Pull Request #1375 · OpenDevicePartnership/patina

kat-perez · 2026-03-06T16:58:19Z

Description

Rewrite discover_console_devices() from a stub into a full implementation that enumerates console protocol handles, builds multi-instance device paths, and writes ConIn, ConOut, and ErrOut UEFI global variables via SetVariable.

Adds EFI_GLOBAL_VARIABLE GUID to patina::guids
Adds build_multi_instance_device_path() helper for constructing multi-instance device paths from protocol handles
Updates is_partial_device_path() to recognize FV/FvFile paths as non-partial
Includes get_variable readback verification with device path display logging

Depends on #1333. Closes #1230

How This Was Tested

Verified on QEMU Q35 with VGA enabled. Console variables written and read back successfully:

ConIn: 24 bytes (SimpleTextInput)
ConOut: 60 bytes (SimpleTextOutput + GOP)
ErrOut: 30 bytes (SimpleTextOutput)

Integration Instructions

N/A

patina-automation · 2026-03-06T16:58:30Z

QEMU Validation Failed

QEMU validation did not complete successfully or did not shutdown as expected.

Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/23162060534

Job Results

Job	Result
Gather Incoming PR Metadata	✅
Run Patina QEMU Validation / Preflight Checks	✅
Run Patina QEMU Validation / Post In-Progress Notification	✅
Run Patina QEMU Validation / Get Constants / Get Repository Constants	✅
Run Patina QEMU Validation / Validate QEMU Q35 (Windows)	✅
Run Patina QEMU Validation / Validate QEMU - SBSA (Linux)	❌
Run Patina QEMU Validation / Validate QEMU - Q35 (Linux)	✅
Run Patina QEMU Validation / Emit PR Metadata	✅

Error Details

qemu-validation-logs-Linux-SBSA/sbsa-linux.log (4 error/warning sections)

warning: patch `patina_boot v20.1.1 (/__w/patina/patina/components/patina_boot)` was not used in the crate graph
help: Check that the patched package version and available features are compatible

warning: patch `patina_boot v20.1.1 (/__w/patina/patina/components/patina_boot)` was not used in the crate graph
help: Check that the patched package version and available features are compatible

warning: patch `patina_boot v20.1.1 (/__w/patina/patina/components/patina_boot)` was not used in the crate graph
help: Check that the patched package version and available features are compatible

warning: patch `patina_boot v20.1.1 (/__w/patina/patina/components/patina_boot)` was not used in the crate graph
help: Check that the patched package version and available features are compatible

This comment was automatically generated by the Patina QEMU PR Validation Post workflow.

codecov · 2026-03-06T17:17:10Z

Codecov Report

❌ Patch coverage is 96.97885% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
components/patina_boot/src/helpers.rs	96.89%	10 Missing ⚠️

📢 Thoughts on this report? Let us know!

makubacki · 2026-03-09T17:17:10Z

@kat-perez, should #1230 be linked to this PR?

kat-perez · 2026-03-09T17:19:12Z

@kat-perez, should #1230 be linked to this PR?

yes, that's the issue I was working on

Rewrite discover_console_devices() to enumerate console protocol handles, build multi-instance device paths, and write ConIn/ConOut/ErrOut UEFI global variables. Adds EFI_GLOBAL_VARIABLE GUID and is_partial_device_path fix for FV/FvFile paths.

…1375) ## Description Rewrite `discover_console_devices()` from a stub into a full implementation that enumerates console protocol handles, builds multi-instance device paths, and writes `ConIn`, `ConOut`, and `ErrOut` UEFI global variables via `SetVariable`. - Adds `EFI_GLOBAL_VARIABLE` GUID to `patina::guids` - Adds `build_multi_instance_device_path()` helper for constructing multi-instance device paths from protocol handles - Updates `is_partial_device_path()` to recognize FV/FvFile paths as non-partial - Includes get_variable readback verification with device path display logging Depends on #1333. Closes #1230 - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Verified on QEMU Q35 with VGA enabled. Console variables written and read back successfully: - ConIn: 24 bytes (SimpleTextInput) - ConOut: 60 bytes (SimpleTextOutput + GOP) - ErrOut: 30 bytes (SimpleTextOutput) ## Integration Instructions N/A

…penDevicePartnership#1375) ## Description Rewrite `discover_console_devices()` from a stub into a full implementation that enumerates console protocol handles, builds multi-instance device paths, and writes `ConIn`, `ConOut`, and `ErrOut` UEFI global variables via `SetVariable`. - Adds `EFI_GLOBAL_VARIABLE` GUID to `patina::guids` - Adds `build_multi_instance_device_path()` helper for constructing multi-instance device paths from protocol handles - Updates `is_partial_device_path()` to recognize FV/FvFile paths as non-partial - Includes get_variable readback verification with device path display logging Depends on OpenDevicePartnership#1333. Closes OpenDevicePartnership#1230 - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Verified on QEMU Q35 with VGA enabled. Console variables written and read back successfully: - ConIn: 24 bytes (SimpleTextInput) - ConOut: 60 bytes (SimpleTextOutput + GOP) - ErrOut: 30 bytes (SimpleTextOutput) ## Integration Instructions N/A

…1375) ## Description Rewrite `discover_console_devices()` from a stub into a full implementation that enumerates console protocol handles, builds multi-instance device paths, and writes `ConIn`, `ConOut`, and `ErrOut` UEFI global variables via `SetVariable`. - Adds `EFI_GLOBAL_VARIABLE` GUID to `patina::guids` - Adds `build_multi_instance_device_path()` helper for constructing multi-instance device paths from protocol handles - Updates `is_partial_device_path()` to recognize FV/FvFile paths as non-partial - Includes get_variable readback verification with device path display logging Depends on #1333. Closes #1230 - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Verified on QEMU Q35 with VGA enabled. Console variables written and read back successfully: - ConIn: 24 bytes (SimpleTextInput) - ConOut: 60 bytes (SimpleTextOutput + GOP) - ErrOut: 30 bytes (SimpleTextOutput) ## Integration Instructions N/A

kat-perez force-pushed the console-discovery branch from 9554b32 to 9ff54bf Compare March 6, 2026 17:27

kat-perez changed the title ~~patina_boot: Implement full console discovery~~ [feature/patina-boot] patina_boot: Implement full console discovery Mar 6, 2026

kat-perez force-pushed the console-discovery branch from 9ff54bf to c03b1c4 Compare March 6, 2026 17:32

kat-perez changed the base branch from main to feature/patina-boot March 6, 2026 17:34

kat-perez force-pushed the feature/patina-boot branch from 0b98841 to b635499 Compare March 6, 2026 18:37

kat-perez force-pushed the console-discovery branch from c03b1c4 to d1e70cf Compare March 6, 2026 18:56

kat-perez marked this pull request as ready for review March 6, 2026 19:07

kat-perez requested review from Javagedes, joschock, makubacki and os-d March 6, 2026 19:07

makubacki linked an issue Mar 9, 2026 that may be closed by this pull request

[Task] patina_boot: Complete ConsoleDiscovery implementation #1230

Open

os-d approved these changes Mar 9, 2026

View reviewed changes

Comment thread components/patina_boot/src/helpers.rs Outdated

Comment thread components/patina_boot/src/helpers.rs Outdated

Comment thread components/patina_boot/src/helpers.rs Outdated

Comment thread components/patina_boot/src/helpers.rs Outdated

kat-perez force-pushed the console-discovery branch 3 times, most recently from 7095a88 to 8098a4b Compare March 10, 2026 15:38

kat-perez requested a review from os-d March 10, 2026 15:41

os-d approved these changes Mar 10, 2026

View reviewed changes

kat-perez linked an issue Mar 13, 2026 that may be closed by this pull request

[Task] patina_boot: Implement full ConsoleDiscovery (write ConIn/ConOut/ErrOut variables) #1281

Closed

makubacki approved these changes Mar 16, 2026

View reviewed changes

Comment thread components/patina_boot/src/helpers.rs Outdated

Comment thread components/patina_boot/src/helpers.rs

Comment thread components/patina_boot/src/helpers.rs Outdated

Comment thread components/patina_boot/src/helpers.rs Outdated

kat-perez force-pushed the console-discovery branch 6 times, most recently from 65e789e to 96beb64 Compare March 16, 2026 18:18

kat-perez force-pushed the console-discovery branch from 96beb64 to 951ccb2 Compare March 16, 2026 18:34

kat-perez force-pushed the feature/patina-boot branch from b635499 to 29f9d6a Compare March 16, 2026 19:10

kat-perez force-pushed the console-discovery branch from 951ccb2 to f828757 Compare March 16, 2026 19:16

kat-perez merged commit 65c2d6a into OpenDevicePartnership:feature/patina-boot Mar 17, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/patina-boot] patina_boot: Implement full console discovery#1375

[feature/patina-boot] patina_boot: Implement full console discovery#1375
kat-perez merged 1 commit intoOpenDevicePartnership:feature/patina-bootfrom
kat-perez:console-discovery

kat-perez commented Mar 6, 2026 •

edited

Loading

Uh oh!

patina-automation Bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

makubacki commented Mar 9, 2026

Uh oh!

kat-perez commented Mar 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kat-perez commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How This Was Tested

Integration Instructions

Uh oh!

patina-automation Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

QEMU Validation Failed

Job Results

Error Details

Uh oh!

codecov Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

makubacki commented Mar 9, 2026

Uh oh!

kat-perez commented Mar 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kat-perez commented Mar 6, 2026 •

edited

Loading

patina-automation Bot commented Mar 6, 2026 •

edited

Loading

codecov Bot commented Mar 6, 2026 •

edited

Loading