Clean and tag unit tests for use with BYOND unit test framework#2426
Closed
amylizzle wants to merge 20 commits intoOpenDreamProject:masterfrom
Closed
Clean and tag unit tests for use with BYOND unit test framework#2426amylizzle wants to merge 20 commits intoOpenDreamProject:masterfrom
amylizzle wants to merge 20 commits intoOpenDreamProject:masterfrom
Conversation
ike709
reviewed
Oct 26, 2025
10 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wixoaGit
requested changes
Dec 9, 2025
| ASSERT(L[b] == 2) | ||
| ASSERT(L["c"] == 3) | ||
| ASSERT(L[c] == null) | ||
| ASSERT(L.len == 3) |
Member
There was a problem hiding this comment.
Why is this removed? Works in BYOND.
Comment on lines
-12
to
-23
|
|
||
| A = list(a = 10) | ||
| A += A | ||
| A.Cut(1, 2) | ||
| ASSERT(A ~= list("a")) | ||
| ASSERT(A["a"] == null) | ||
|
|
||
| A = list(a = 10) | ||
| A += A | ||
| A.Cut(2, 0) | ||
| ASSERT(A ~= list("a")) | ||
| ASSERT(A["a"] == null) No newline at end of file |
Comment on lines
-9
to
-14
| ASSERT(L1.len == 2) | ||
|
|
||
| // Lists are fun | ||
| L1 += L2 | ||
| ASSERT(L1[3] == "B") | ||
| ASSERT(L1.len == 3) No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes byte order marks from all tests, and adds
// NOBYONDtag to ones which will not work with BYONDAlso fixes/deletes a few tests that did not run properly in BYOND (including some in BrokenTests)
This way we can keep things synced with https://github.com/spacestation13/dm-test-suite easily and double check our tests all work in BYOND (they don't lol)