Conversation
|
Issue I'm dealing with while doing manual testing. cc: @josephjclark
|
The fix for this bug I was facing was sitting all the base in https://github.com/OpenFn/kit/blob/main/packages/project/src/util/base-merge.ts |
|
Issue: changing the id of a step results in this error: |
|
Issue: removing the |
|
Issue: changes to edges don't seem to manifest in the rich diff (I do see them in JSON) |
josephjclark
left a comment
There was a problem hiding this comment.
Looks really cool!
I've tested around a bit and found some issues. But before we go too much further I'm not sure the architecture is right, and I'd like to dig into that a bit with you later
|
Suggestion: When a user hits divergence because the project on remote changed but the locally pulled project has zero changes since last pulled. |
This has been resolved. It happens when you change the id of a job but then didn't do same for all edges referencing it. The error has been updated to print out a bit more meaningful message. |
|
I've done several manual testing on this and it works fine. |

Short Description
A one or two-sentence description of what this PR does.
Fixes #1182
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
List any considerations/cases/advice for testing/QA here.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.