fix(project): include trigger reply fields in version hash#1362
Conversation
josephjclark
left a comment
josephjclark
left a comment
There was a problem hiding this comment.
Thank you @officialasishkumar! This is cool. Just a couple of tidy ups before I can merge it
| `@name wf-1 | ||
| @id workflow-id | ||
| t(type=cron,cron_expression="1")-a | ||
| a-b |
There was a problem hiding this comment.
You shouldn't need the a-b nodes here at all right? Better to clean that up and keep the tests simple
There was a problem hiding this comment.
Removed the extra nodes and kept the test minimal in f021d98.
|
Oh and @officialasishkumar we like contributors to disclose AI usage in some way so that everyone knows where we stand. We have a checkbox for this in the PR template. Can you update the PR description to at least say "I have used AI to generate this PR"? I've updated the PR description to remove the weird validation stuff. It's enough in this case that tests are passing in CI |
|
Hi @josephjclark , yes, i have used AI in research and understanding the codebase |
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
officialasishkumar
force-pushed
the
fix/version-hash-trigger-keys
branch
from
242e36c to
f021d98
Compare
josephjclark
left a comment
josephjclark
left a comment
There was a problem hiding this comment.
Thanks @officialasishkumar 🙏
* engine: Set max-old-space-size on child process #1368 --------- Co-authored-by: Joe Clark <jclark@openfn.org> * fix(project): include trigger reply fields in version hash (#1362) Signed-off-by: Asish Kumar <officialasishkumar@gmail.com> * fix state growth (#1371) * versions --------- Signed-off-by: Asish Kumar <officialasishkumar@gmail.com> Co-authored-by: Taylor Downs <taylor@openfn.org> Co-authored-by: Asish Kumar <87874775+officialasishkumar@users.noreply.github.com>
2 participants
Description
This keeps the project-side workflow version hash aligned with Lightning by including
webhook_replyandcron_cursor_job_idin the trigger field list used bygenerateHash().Without this, the CLI can compute a different hash from Lightning for the same workflow after those trigger fields change.
Changes
webhook_replyandcron_cursor_job_idinpackages/project/src/util/version.tspackages/project/test/util/version-workflow.test.tsCompanion to OpenFn/lightning#4599.
AI Usage
Used only for research.