Open
Conversation
- Extract shared JsonViewer component (Monaco + copy button) from DataclipViewer - Add CollectionPreviewViewer with string truncation for long values - Wire up preview button and modal in CollectionsComponent showing the first item - Register CollectionPreviewViewer as an esbuild entry point - Add LiveView and frontend tests
…splay
Collection values are stored as raw strings in the DB. When wrapped in
the download format ([{key, value, created, updated}]), JSON values get
double-encoded into unreadable escaped strings. This recursively parses
value fields that contain valid JSON so truncateStrings can walk into
the real structure. Also reorders keys so key appears first.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4619 +/- ##
=======================================
Coverage 89.61% 89.62%
=======================================
Files 444 444
Lines 21505 21548 +43
=======================================
+ Hits 19272 19312 +40
- Misses 2233 2236 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Security ReviewClaude hit the max-turns limit or encountered an error before posting findings. See the workflow run for details. |
Collaborator
|
This might need an update after #4613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a collection preview modal to project settings. Each collection row gets an eye icon button that opens a modal showing the first record as formatted JSON, so users can quickly check what's in a collection without downloading it.
Built on @midigofrank's initial implementation in 4528-frank-preview-collections, with changes on top.
Closes #4528
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)